Re: [HACKERS] [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Jim C. Nasby
On Wed, Mar 08, 2006 at 04:57:52PM -0500, Neil Conway wrote: > On Wed, 2006-03-08 at 08:20 -0800, David Fetter wrote: > > The previous discussion showed that there is a wide diversity of > > opinions on what The Right Delimiter and The Right NULL String(TM) > > are. > > Barring a more convincing j

Re: [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Neil Conway
On Wed, 2006-03-08 at 08:20 -0800, David Fetter wrote: > The previous discussion showed that there is a wide diversity of > opinions on what The Right Delimiter and The Right NULL String(TM) > are. Barring a more convincing justification for why we need this feature, I'm inclined to side with Tom:

Re: [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
On Wed, Mar 08, 2006 at 11:10:04AM -0500, Neil Conway wrote: > On Wed, 2006-03-08 at 07:47 -0800, David Fetter wrote: > > From the earlier discussion, it appears that there is a variety of > > opinions on what the COPY delimiter should be in pg_dump. This patch > > allows people to set it and the

Re: [PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Neil Conway
On Wed, 2006-03-08 at 07:47 -0800, David Fetter wrote: > From the earlier discussion, it appears that there is a variety of > opinions on what the COPY delimiter should be in pg_dump. This patch > allows people to set it and the NULL string. I'm still not convinced there is a reasonable use-case

[PATCHES] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
Folks, >From the earlier discussion, it appears that there is a variety of opinions on what the COPY delimiter should be in pg_dump. This patch allows people to set it and the NULL string. Thanks to Gavin Sherry for help with the pointers :) I didn't patch pg_dumpall, but it would be trivial if