Re: [PATCHES] Add usage counts to pg_buffercache

2007-04-07 Thread Bruce Momjian
Patch applied. Thanks. --- Greg Smith wrote: This patch adds the usage count statistic to the information available in contrib/pgbuffercache. Earlier this month a discussion about my first attempt to instrument the

Re: [PATCHES] Add usage counts to pg_buffercache

2007-04-02 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

[PATCHES] Add usage counts to pg_buffercache

2007-03-31 Thread Greg Smith
This patch adds the usage count statistic to the information available in contrib/pgbuffercache. Earlier this month a discussion about my first attempt to instrument the background writer had Tom asking for details about the usage histogram I was seeing, and this patch proved to be the

Re: [PATCHES] Add usage counts to pg_buffercache

2007-03-31 Thread Russell Smith
Possibly minor detail; from buf_internals.h uint16usage_count;/* usage counter for clock sweep code */ and you have a int16 to store that. Currently the max buffer count is 5. But is that a complete safe assumption? Maybe a compile time check that BM_MAX_USAGE_COUNT is 16k

Re: [PATCHES] Add usage counts to pg_buffercache

2007-03-31 Thread Greg Smith
On Sun, 1 Apr 2007, Russell Smith wrote: Currently the max buffer count is 5. But is that a complete safe assumption? Maybe a compile time check that BM_MAX_USAGE_COUNT is 16k would ensure that things don't go wrong? I actually wasn't even aware that was a hard limit; I just assumed that