Re: [PATCHES] CREATE TABLE LIKE x INCLUDING CONSTRAINTS

2006-06-26 Thread Bruce Momjian
Patch applied. Thanks. --- Greg Stark wrote: Fixed previous patch by calling change_varattnos_of_a_node() to fix up constraint expressions in case attribute positions don't line up. change_varattnos_of_a_node is in

[PATCHES] CREATE TABLE LIKE x INCLUDING CONSTRAINTS

2006-06-20 Thread Greg Stark
Fixed previous patch by calling change_varattnos_of_a_node() to fix up constraint expressions in case attribute positions don't line up. change_varattnos_of_a_node is in tablecmds.c for inherited tables so this means making it extern. I have a feeling it probably ought to move to some file of

Re: [PATCHES] CREATE TABLE LIKE x INCLUDING CONSTRAINTS

2006-06-20 Thread Alvaro Herrera
Hum, how are you handling the case where I specify CREATE TABLE LIKE x INCLUDING CONSTRAINTS EXCLUDING CONSTRAINTS ? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of

Re: [PATCHES] CREATE TABLE LIKE x INCLUDING CONSTRAINTS

2006-06-20 Thread Greg Stark
Alvaro Herrera [EMAIL PROTECTED] writes: Hum, how are you handling the case where I specify CREATE TABLE LIKE x INCLUDING CONSTRAINTS EXCLUDING CONSTRAINTS ? I have the last one taking priority. I could make it an error but don't see much point in doing so. It seems to be making something