[PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Christopher Kings-Lynne
Hi, Attached patch enables dumping of LOB comments when in text mode. I really don't get the binary/custom format LOB stuff (and don't have time to investigate), so perhaps someone else can do that. Having it in text format is still an improvement though. Chris blobcomments.txt.gz

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Attached patch enables dumping of LOB comments when in text mode. I really don't get the binary/custom format LOB stuff (and don't have time to investigate), so perhaps someone else can do that. That's pretty icky :-(. I think the right way

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Alvaro Herrera
On Wed, Jun 29, 2005 at 11:05:43PM -0400, Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: Attached patch enables dumping of LOB comments when in text mode. I really don't get the binary/custom format LOB stuff (and don't have time to investigate), so perhaps someone else

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Christopher Kings-Lynne
Attached patch enables dumping of LOB comments when in text mode. I really don't get the binary/custom format LOB stuff (and don't have time to investigate), so perhaps someone else can do that. That's pretty icky :-(. I think the right way is more like this. Hehe - in the world of open

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Tom Lane
Alvaro Herrera [EMAIL PROTECTED] writes: On Wed, Jun 29, 2005 at 11:05:43PM -0400, Tom Lane wrote: That's pretty icky :-(. I think the right way is more like this. Wow, that's complex. No wonder I wasn't able to come up with a patch to dump ALTER DATABASE commands some time ago. The trick

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Christopher Kings-Lynne
The trick in hacking pg_dump is to understand which layer you need to modify. The whole thing seems overly complex to me :-( ... but redesigning it is a project for another release cycle. I just find the whole BLOB handling very tricky to understand :( I vote that we combine pg_dumpall and

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: we can possibly gain custom format full cluster dumps. Do we care? The main rationale for inventing a custom format, as I recall it, was (a) plain text couldn't hack blobs and (b) you needed the ability to rearrange the dump order to work around

Re: [PATCHES] Dump comments on large objects in text mode

2005-06-29 Thread Alvaro Herrera
On Wed, Jun 29, 2005 at 11:44:58PM -0400, Tom Lane wrote: (BTW: Alvaro, I've been having direct mail to you bounce lately --- let's see if this goes through ...) Yeah, sorry about that :-( I realized I must change mail provider ASAP when I noticed it's been eating my own emails (e.g. the