Re: [PATCHES] Fix for file names with spaces

2005-10-05 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 05 October 2005 16:08 > To: Bruce Momjian > Cc: PostgreSQL-patches; Dave Page > Subject: Re: [PATCHES] Fix for file names with spaces > > Bruce Momjian writes: > > Sorry, this is

Re: [PATCHES] Fix for file names with spaces

2005-10-05 Thread Tom Lane
"Dave Page" writes: >> Why does this patch convert '\' to '\\' and not to '/' ? > Because support on Windows for / is somewhat inconsistent outside of the > Msys shell. Do we care about that for the purposes that pg_config will be used for? It seems more likely to me that emitting \\ will break

Re: [PATCHES] Fix for file names with spaces

2005-10-05 Thread Dave Page
> -Original Message- > From: Tom Lane [mailto:[EMAIL PROTECTED] > Sent: 05 October 2005 16:31 > To: Dave Page > Cc: Bruce Momjian; PostgreSQL-patches > Subject: Re: [PATCHES] Fix for file names with spaces > > "Dave Page" writes: > >> Why

Re: [PATCHES] Fix for file names with spaces

2005-10-05 Thread Tom Lane
Bruce Momjian writes: > Sorry, this is the same patch with the proper subject line. Why does this patch convert '\' to '\\' and not to '/' ? AFAICS that does nothing except to make the code more fragile. regards, tom lane ---(end of broadcast)

[PATCHES] Fix for file names with spaces

2005-10-05 Thread Bruce Momjian
Sorry, this is the same patch with the proper subject line. --- Bruce Momjian wrote: > > Patch applied. Thanks. > > --- > > > Bruce Momjian wrote: