Re: [PATCHES] Foreign key type checking patch

2004-06-09 Thread Fabien COELHO
Dear Tom, Thanks for your reply. Here is a proposed patch against 7.4.1 to check exact match of foreign key types wrt the referenced keys, and to show a warning if this is not the case. I think that this concern may be obsolete in CVS tip, I just get the current CVS and had a quick

[PATCHES] Foreign key type checking patch

2004-03-01 Thread Fabien COELHO
Hello again patchers, Here is a proposed patch against 7.4.1 to check exact match of foreign key types wrt the referenced keys, and to show a warning if this is not the case. This is an attempt to prevent stupid bugs such as : CREATE TABLE foo(id INT4 NOT NULL PRIMARY KEY); CREATE TABLE

Re: [PATCHES] Foreign key type checking patch

2004-03-01 Thread Tom Lane
Fabien COELHO [EMAIL PROTECTED] writes: Here is a proposed patch against 7.4.1 to check exact match of foreign key types wrt the referenced keys, and to show a warning if this is not the case. I think that this concern may be obsolete in CVS tip, at least for the cases where we have indexable

Re: [PATCHES] Foreign key type checking patch

2004-03-01 Thread Tom Lane
Stephan Szabo [EMAIL PROTECTED] writes: I'm really not sure that it makes sense to warn for the fk cases where the semantics should be correct (if they're not we need to fix it or make it an error) but in which an error might have been made by the user because the types are different given

Re: [PATCHES] Foreign key type checking patch

2004-03-01 Thread Fabien COELHO
I can think of several cases where it might be reasonable for the types to be different. Sure. It's all about a warning, not about an error. -- Fabien Coelho - [EMAIL PROTECTED] ---(end of broadcast)--- TIP 7: don't forget to increase your