Re: [PATCHES] Install pg_regress by default
Peter Eisentraut wrote: Alvaro Herrera wrote: This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? If you do, there should also be documentation, such as a reference page, about how to use it. Applied with corrections, except for this. I'll do that later today. Thanks, -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match
Re: [PATCHES] Install pg_regress by default
Peter Eisentraut wrote: Alvaro Herrera wrote: This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? If you do, there should also be documentation, such as a reference page, about how to use it. Ok, documented in the xfunc.sgml page, where the rest of PGXS is documented. Feel free to editorialize ... -- Alvaro Herrerahttp://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Install pg_regress by default
Alvaro Herrera wrote: This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? Scripts should be installed using INSTALL_SCRIPT (not _PROGRAM). -- Peter Eisentraut http://developer.postgresql.org/~petere/ ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
[PATCHES] Install pg_regress by default
This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. Index: src/Makefile === RCS file: /home/alvherre/cvs/pgsql/src/Makefile,v retrieving revision 1.36 diff -c -r1.36 Makefile *** src/Makefile13 Jan 2005 18:23:21 - 1.36 --- src/Makefile3 Nov 2005 21:29:55 - *** *** 24,29 --- 24,30 $(MAKE) -C pl $@ $(MAKE) -C makefiles $@ $(MAKE) -C utils $@ + $(MAKE) -C test/regress $@ install: install-local Index: src/test/regress/GNUmakefile === RCS file: /home/alvherre/cvs/pgsql/src/test/regress/GNUmakefile,v retrieving revision 1.53 diff -c -r1.53 GNUmakefile *** src/test/regress/GNUmakefile1 Nov 2005 15:09:11 - 1.53 --- src/test/regress/GNUmakefile21 Nov 2005 20:42:14 - *** *** 55,60 --- 55,62 $ $@ chmod a+x $@ + install: pg_regress + $(INSTALL_PROGRAM) pg_regress $(DESTDIR)$(pgxsdir)/$(subdir)/pg_regress # Build dynamically-loaded object file for CREATE FUNCTION ... LANGUAGE 'C'. ---(end of broadcast)--- TIP 6: explain analyze is your friend
Re: [PATCHES] Install pg_regress by default
Alvaro Herrera [EMAIL PROTECTED] writes: This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? I've forgotten the details, but it seems like there was something else that this depended on to be of any use? What are you envisioning people doing with it? BTW, I think you need an uninstall target too. regards, tom lane ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] Install pg_regress by default
Tom Lane wrote: Alvaro Herrera [EMAIL PROTECTED] writes: This patch allows pg_regress to be installed by default. This was proposed awhile back but never done, any objections if I commit this? I've forgotten the details, but it seems like there was something else that this depended on to be of any use? What are you envisioning people doing with it? Actually it works, as you discovered some time ago, using PGXS. I use it to test PL/php. (Yes, I'm hacking on that ugly thing.) I think other module authors would also have some sort of regression testing; having this in place eases things a bit. I guess people whose packages need to support systems without PGXS already have some testing harness in place, so it will be less useful to them. BTW, I think you need an uninstall target too. Ok. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ---(end of broadcast)--- TIP 5: don't forget to increase your free space map settings
