Re: [PATCHES] Make CLUSTER MVCC-safe

2007-04-07 Thread Tom Lane
Heikki Linnakangas [EMAIL PROTECTED] writes: This patch makes CLUSTER MVCC-safe. Visibility information and update chains are preserved like in VACUUM FULL. Here's an update, fixing conflict by Tom's recent commit of Simon's patch to skip WAL-inserts when archiving is not enabled. Applied

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-04-02 Thread Bruce Momjian
Heikki Linnakangas wrote: Alvaro Herrera wrote: Heikki Linnakangas wrote: Here's an update, fixing conflict by Tom's recent commit of Simon's patch to skip WAL-inserts when archiving is not enabled. Hmm, wouldn't it be better if the rewriteheap.c file was in access/heap/ instead of

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-30 Thread Heikki Linnakangas
Alvaro Herrera wrote: Heikki Linnakangas wrote: Here's an update, fixing conflict by Tom's recent commit of Simon's patch to skip WAL-inserts when archiving is not enabled. Hmm, wouldn't it be better if the rewriteheap.c file was in access/heap/ instead of commands/? Yeah, maybe. I thought

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-29 Thread Heikki Linnakangas
Here's an update, fixing conflict by Tom's recent commit of Simon's patch to skip WAL-inserts when archiving is not enabled. Heikki Linnakangas wrote: This patch makes CLUSTER MVCC-safe. Visibility information and update chains are preserved like in VACUUM FULL. I created a new generic

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-29 Thread Alvaro Herrera
Heikki Linnakangas wrote: Here's an update, fixing conflict by Tom's recent commit of Simon's patch to skip WAL-inserts when archiving is not enabled. Hmm, wouldn't it be better if the rewriteheap.c file was in access/heap/ instead of commands/? -- Alvaro Herrera

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-21 Thread Simon Riggs
On Tue, 2007-03-20 at 18:20 +, Heikki Linnakangas wrote: This patch makes CLUSTER MVCC-safe. Visibility information and update chains are preserved like in VACUUM FULL. Sounds good. CLUSTER is currently the only user of the facility, but I'm envisioning we might have other users in the

Re: [PATCHES] Make CLUSTER MVCC-safe

2007-03-21 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

[PATCHES] Make CLUSTER MVCC-safe

2007-03-20 Thread Heikki Linnakangas
This patch makes CLUSTER MVCC-safe. Visibility information and update chains are preserved like in VACUUM FULL. I created a new generic rewriteheap-facility to handle rewriting tables in a visibility-preserving manner. All the update chain tracking is done in rewriteheap.c, the caller is