Re: [PATCHES] New version of GENERATED/IDENTITY, was Re: parser dilemma

2007-04-27 Thread Bruce Momjian
Zoltan Boszormenyi wrote: Thanks. But actually it didn't showed up at that page. For that matter, neither patch showed up on either pgpatches or pgpatches_hold that you indicated yesterday. My apologies. Something was misconfigured on my end. The web pages are fixed now.

[PATCHES] New version of GENERATED/IDENTITY, was Re: parser dilemma

2007-04-26 Thread Zoltan Boszormenyi
Hi, here's the patch with the modifications suggested by Tom Lane. The postfix rule was deleted from b_expr and the reverse parsing in ruleutils.c::get_oper_expr() always puts parentheses around postfix operators. Other changes: - OVERRIDING SYSTEM VALUE in COPY can appear at any place in the

Re: [PATCHES] New version of GENERATED/IDENTITY, was Re: parser dilemma

2007-04-26 Thread Zoltan Boszormenyi
And here it is attached. Sorry. Zoltan Boszormenyi írta: Hi, here's the patch with the modifications suggested by Tom Lane. The postfix rule was deleted from b_expr and the reverse parsing in ruleutils.c::get_oper_expr() always puts parentheses around postfix operators. Other changes: -

Re: [PATCHES] New version of GENERATED/IDENTITY, was Re: parser dilemma

2007-04-26 Thread Zoltan Boszormenyi
Hi, some last changes. Really. :-) I made ALTER TABLE symmetric with CREATE TABLE so the grammar now has: ALTER TABLE tabname ALTER colname SET GENERATED { ALWAYS | BY DEFAULT} AS IDENTITY [ ( sequence options )] This works intuitively the same as in CREATE TABLE, i.e. - it creates an OWNED

Re: [PATCHES] New version of GENERATED/IDENTITY, was Re: parser dilemma

2007-04-26 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---