Re: [PATCHES] Proposed patch for 8.3 VACUUM FULL crash

2008-02-11 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Tom Lane [EMAIL PROTECTED] writes: On investigation the problem occurs because we changed vacuum.c's PageGetFreeSpaceWithFillFactor() to use PageGetHeapFreeSpace() instead of just computing pd_upper - pd_lower as it had done in every previous release.

Re: [PATCHES] Proposed patch for 8.3 VACUUM FULL crash

2008-02-11 Thread Gregory Stark
Tom Lane [EMAIL PROTECTED] writes: On investigation the problem occurs because we changed vacuum.c's PageGetFreeSpaceWithFillFactor() to use PageGetHeapFreeSpace() instead of just computing pd_upper - pd_lower as it had done in every previous release. This was *not* a good idea: VACUUM FULL

[PATCHES] Proposed patch for 8.3 VACUUM FULL crash

2008-02-10 Thread Tom Lane
Tomas Szepe reported here http://archives.postgresql.org/pgsql-bugs/2008-02/msg00068.php about a bug in VACUUM FULL, which turned out to be that the code was expecting pages with no live tuples to always get added to the fraged_pages list, and this was sometimes not happening. On investigation