Neil Conway [EMAIL PROTECTED] wrote:
--- 622,628
for (i = 0; i (sizeof(DDLAFTERs) / sizeof(char *)); i++)
{
res = PQexec(con, DDLAFTERs[i]);
! if (strncmp(DDLAFTERs[i], drop, 4) PQresultStatus(res) !=
PGRES_COMMAND_OK)
{
ITAGAKI Takahiro wrote:
But this code seems to be an idiom,
Check the result, but drop commands may be fail.
Drop commands might be added to DDLAFTERs some time, so we may leave it.
Possibly, but I think checking for something that cannot occur is
confusing to the reader (and besides, it is
DDLs was used instead of DDLAFTERs by mistake.
*** pgbench.c Tue Nov 9 15:09:31 2004
--- pgbench.fix.c Mon May 23 12:50:01 2005
*** init(void)
*** 622,628
for (i = 0; i (sizeof(DDLAFTERs) / sizeof(char *)); i++)
{
res = PQexec(con,
ITAGAKI Takahiro wrote:
--- 622,628
for (i = 0; i (sizeof(DDLAFTERs) / sizeof(char *)); i++)
{
res = PQexec(con, DDLAFTERs[i]);
! if (strncmp(DDLAFTERs[i], drop, 4) PQresultStatus(res) !=
PGRES_COMMAND_OK)
{
