Re: [PATCHES] database file compatibility patch

2005-10-02 Thread Tom Lane
Qingqing Zhou <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> wrote >> There's not much need to check endianness explicitly, since the >> pg_control_version check will surely fail if there's an endianness >> discrepancy (not to mention the other checks on pg_control fields). > Oh, rig

Re: [PATCHES] database file compatibility patch

2005-10-02 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> wrote > > There's not much need to check endianness explicitly, since the > pg_control_version check will surely fail if there's an endianness > discrepancy (not to mention the other checks on pg_control fields). > Oh, right. So for the same reason, is it safe to r

Re: [PATCHES] database file compatibility patch

2005-10-02 Thread Tom Lane
Qingqing Zhou <[EMAIL PROTECTED]> writes: > This patches checks MAXIMUM_ALIGNOF and endian to make sure that the > database file used is compatible with the server version. I missed seeing this patch in my inbox, so wrote and applied my own version earlier today. Sorry for the missed communicatio

[PATCHES] database file compatibility patch

2005-10-02 Thread Qingqing Zhou
This patches checks MAXIMUM_ALIGNOF and endian to make sure that the database file used is compatible with the server version. We use SHORT_ALIGNOF, INT_ALIGNOF, DOUBLE_ALIGNOF and MAXIMUM_ALIGNOF (which is just the largest of these) to align columns within a row (see att_align()) or rows within a