Re: [PATCHES] error report on slru.c

2004-10-03 Thread Gaetano Mendola
Tom Lane wrote: Peter Eisentraut <[EMAIL PROTECTED]> writes: Tom Lane wrote: This violates the message style guidelines, IMHO. My first impression is that it should be swapped. The error is that the file could not be opened. The detail is that the files is related to transaction status informa

Re: [PATCHES] error report on slru.c

2004-10-03 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This violates the message style guidelines, IMHO. > My first impression is that it should be swapped. The error is that the > file could not be opened. The detail is that the files is related to > transaction status information.

Re: [PATCHES] error report on slru.c

2004-10-03 Thread Peter Eisentraut
Tom Lane wrote: > Gaetano Mendola <[EMAIL PROTECTED]> writes: > > here a patch that > > 1) Rise the information about the file missing on pg_clog from > > detail to error > > This violates the message style guidelines, IMHO. My first impression is that it should be swapped. The error is that

Re: [PATCHES] error report on slru.c

2004-10-03 Thread Gaetano Mendola
Tom Lane wrote: Gaetano Mendola <[EMAIL PROTECTED]> writes: here a patch that 1) Rise the information about the file missing on pg_clog from detail to error This violates the message style guidelines, IMHO. Tom, your opinion is not humble but is is really appreciated, however I think that a mis

Re: [PATCHES] error report on slru.c

2004-10-02 Thread Tom Lane
Gaetano Mendola <[EMAIL PROTECTED]> writes: > here a patch that > 1) Rise the information about the file missing on pg_clog from > detail to error This violates the message style guidelines, IMHO. > 2) Insert the offset information also for a missing file It's hardly necessary, since the tra

[PATCHES] error report on slru.c

2004-10-02 Thread Gaetano Mendola
Hi all, here a patch that 1) Rise the information about the file missing on pg_clog from detail to error 2) Insert the offset information also for a missing file I did it with the 8.0beta2 sources Regards Gaetano Mendola --- slru.c.orig 2004-10-02 10:56:01.0 +0200 +++ slru.c 2004