[PATCHES] make installcheck on non-default ports

[Joe Conway]

I was trying to set up my dev box for multiple simultaneous Postgres 
installs (7.3 stable, 7.4 stable, cvs head) and discovered that
`make installcheck` did not honor the default port assigned at configure 
time. I view this as a bug.

The attached resolves the issue for all three versions.

Any objections to me applying this to cvs head? What about 7.3 and 7.4 
stable branches?

Thanks,

Joe
Index: src/test/regress/GNUmakefile
===
RCS file: /cvsroot/pgsql-server/src/test/regress/GNUmakefile,v
retrieving revision 1.43
diff -c -r1.43 GNUmakefile
*** src/test/regress/GNUmakefile2 Nov 2003 21:56:15 -   1.43
--- src/test/regress/GNUmakefile26 Nov 2003 04:00:38 -
***
*** 122,128 
$(SHELL) ./pg_regress --temp-install --top-builddir=$(top_builddir) 
--schedule=$(srcdir)/parallel_schedule --multibyte=$(MULTIBYTE) $(MAXCONNOPT)
  
  installcheck: all
!   $(SHELL) ./pg_regress --schedule=$(srcdir)/serial_schedule 
--multibyte=$(MULTIBYTE)
  
  
  # old interfaces follow...
--- 122,128 
$(SHELL) ./pg_regress --temp-install --top-builddir=$(top_builddir) 
--schedule=$(srcdir)/parallel_schedule --multibyte=$(MULTIBYTE) $(MAXCONNOPT)
  
  installcheck: all
!   $(SHELL) ./pg_regress --port=$(DEF_PGPORT) 
--schedule=$(srcdir)/serial_schedule --multibyte=$(MULTIBYTE)
  
  
  # old interfaces follow...
***
*** 131,137 
  runtest: installcheck
  
  bigtest:
!   $(SHELL) ./pg_regress --schedule=$(srcdir)/serial_schedule 
--multibyte=$(MULTIBYTE) numeric_big
  
  bigcheck:
$(SHELL) ./pg_regress --temp-install --top-builddir=$(top_builddir) 
--schedule=$(srcdir)/parallel_schedule --multibyte=$(MULTIBYTE) $(MAXCONNOPT) 
numeric_big
--- 131,137 
  runtest: installcheck
  
  bigtest:
!   $(SHELL) ./pg_regress --port=$(DEF_PGPORT) 
--schedule=$(srcdir)/serial_schedule --multibyte=$(MULTIBYTE) numeric_big
  
  bigcheck:
$(SHELL) ./pg_regress --temp-install --top-builddir=$(top_builddir) 
--schedule=$(srcdir)/parallel_schedule --multibyte=$(MULTIBYTE) $(MAXCONNOPT) 
numeric_big

---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org

Re: [PATCHES] make installcheck on non-default ports

[Tom Lane]

Joe Conway [EMAIL PROTECTED] writes:
 I was trying to set up my dev box for multiple simultaneous Postgres 
 installs (7.3 stable, 7.4 stable, cvs head) and discovered that
 `make installcheck` did not honor the default port assigned at configure 
 time. I view this as a bug.

I think there is something wrong with your setup procedures, because
I've never needed such.  (I've corresponded with Joe off-list about
this --- maybe we can produce a FAQ about the right way to do it once
the dust settles.)

 Any objections to me applying this to cvs head?

AFAICS this would defeat the documented behavior of being able to set
PGHOST/PGPORT in the environment to control which postmaster make
installcheck will speak to.  So, yeah, I think it's a bad idea.

regards, tom lane

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings