Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-06-16 Thread Bruce Momjian
Added to TODO: o Fix problems with RETURN NEXT on tables with dropped/added columns after function creation http://archives.postgresql.org/pgsql-patches/2006-02/msg00165$ --- Sergey E. Koposov wr

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-03-02 Thread Bruce Momjian
Needs cleaning up. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it.

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-19 Thread Neil Conway
On Sun, 2006-02-12 at 20:15 +0300, Sergey E. Koposov wrote: > I'm proposing the fix of this bug: > http://archives.postgresql.org/pgsql-hackers/2005-02/msg00498.php I think the suggested logic for compatible_tupdesc() is still wrong. For example, the patch rejects the following: create table usno

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-15 Thread Tom Lane
"Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > Are there any problems with that patch to not be applied ? Hasn't been reviewed yet ... see nearby discussions about shortage of patch reviewers ... > (Sorry if I'm hurrying) At the moment it's not unusual for nontrivial patches to sit around fo

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-15 Thread Sergey E. Koposov
On Sun, 12 Feb 2006, Tom Lane wrote: > "Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > > The problem with that is in fact in pl_exec.c in function > > compatible_tupdesc(), which do not check for the deleted attributes. > > Is that really the only problem? Tom, Are there any problems with tha

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-12 Thread Sergey E. Koposov
On Sun, 12 Feb 2006, Tom Lane wrote: > "Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > > The problem with that is in fact in pl_exec.c in function > > compatible_tupdesc(), which do not check for the deleted attributes. > > Is that really the only problem? I cannot be completely sure in that,

Re: [PATCHES] patch fixing the old RETURN NEXT bug

2006-02-12 Thread Tom Lane
"Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > The problem with that is in fact in pl_exec.c in function > compatible_tupdesc(), which do not check for the deleted attributes. Is that really the only problem? regards, tom lane ---(end of broadca

[PATCHES] patch fixing the old RETURN NEXT bug

2006-02-12 Thread Sergey E. Koposov
Hello All, I'm proposing the fix of this bug: http://archives.postgresql.org/pgsql-hackers/2005-02/msg00498.php The exact SQL code exposing the error: -- create table usno (ra real, dec real, bmag real, rmag real,ipix int8); CREATE OR REPLACE FUNCTION xxx(refcursor) RETURNS refcursor AS