Re: [PATCHES] patch for pg_autovacuum 8.0.x prevent segv for dropped tables

2005-10-20 Thread daveg
On Thu, Oct 20, 2005 at 12:30:27PM -0400, Tom Lane wrote: > "Matthew T. O'Connor" writes: > > Tom Lane wrote: > >> Surely this is completely broken? AFAICT you are testing the result > >> from a VACUUM or ANALYZE command, which is not going to return any > >> tuples. > > > Upon further inspectio

Re: [PATCHES] patch for pg_autovacuum 8.0.x prevent segv for dropped tables

2005-10-20 Thread Tom Lane
"Matthew T. O'Connor" writes: > Tom Lane wrote: >> Surely this is completely broken? AFAICT you are testing the result >> from a VACUUM or ANALYZE command, which is not going to return any >> tuples. > Upon further inspection, I think you are right. I would think that > instead of checking the

Re: [PATCHES] patch for pg_autovacuum 8.0.x prevent segv for dropped tables

2005-10-20 Thread Tom Lane
daveg <[EMAIL PROTECTED]> writes: > Below is a patch for this that should apply against any 8.0.x. The change > verifies that the catalog query returned some rows before accessing the row > data. Surely this is completely broken? AFAICT you are testing the result from a VACUUM or ANALYZE command,

[PATCHES] patch for pg_autovacuum 8.0.x prevent segv for dropped tables

2005-10-20 Thread daveg
Apologies if this is old news, but pg_autovacuum in 8.0.x has the bad habit of SEGVing and exiting when a table gets dropped out from under it. This creates problems if you rely on pg_autovacuum for the bulk of your vacuuming as it forgets it's statistics when it is restarted and so will skip some