Re: [PATCHES] pg_ctl cleanup

2004-10-14 Thread Neil Conway
On Thu, 2004-10-14 at 15:09, Neil Conway wrote: This patch makes a couple small changes to pg_ctl [...] A slightly revised version of the patch was applied to HEAD; the revised patch is attached. -Neil Index: src/bin/pg_ctl/pg_ctl.c

[PATCHES] pg_ctl cleanup

2004-10-13 Thread Neil Conway
This patch makes a couple small changes to pg_ctl: - refactor a bunch of code to call a separate function print_msg() which checks whether silent mode is enabled before printing an error message. I could have made print_msg() take a varargs list, but I didn't bother (worse is better). Also, we do