Re: [PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Magnus Hagander
>I can test cygwin too. But just out of curiosity; why would 
>anyone want 
>to use cygwin with 8.0?

It runs on 9x, native requires NT. There are still a lot of ppl on 9x. I
wouldn't expect a production server on 9x (indeed not a server at all),
but certainly some desktops that are using it.

//Magnus

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Thomas Hallgren
Fabien COELHO wrote:
I have no mean to test that on a win32 machine. Could you do it?
 

Sure, I'll test it sometime tomorrow or the day after. I'll get back to you.
I'm wondering whether the MAKE_DLL fix should also be done under cygwin.
Any opinion?
 

I can test cygwin too. But just out of curiosity; why would anyone want 
to use cygwin with 8.0?

Regards,
Thomas Hallgren

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


[PATCHES] pgxs under Win32 for PL/Java

2004-11-07 Thread Fabien COELHO

Dear Thomas,

> I'm trying to change the Makefile system for PL/Java so that it uses
> PGXS instead of compiling using a complete PostgreSQL source tree. As it
> turns out, the directory "include/port/win32" is not present in the
> PostgreSQL binary installation. Without it, it's not possible to compile
> on win32.

Please find enclosed a patch which attempts to fix your use of pgxs under
win32:
- install port/* includes
- install libpostgres.a by default (it seems to require MAKE_DLL=true)
- fix include path under win32 portname

The specific win32 fixes are performed in the Makefile.win32 file.

I have no mean to test that on a win32 machine. Could you do it?

I'm wondering whether the MAKE_DLL fix should also be done under cygwin.
Any opinion?

Thanks in advance,

-- 
Fabien Coelho - [EMAIL PROTECTED]*** ./src/include/Makefile.orig Wed Nov  3 10:32:29 2004
--- ./src/include/Makefile  Sun Nov  7 11:14:52 2004
***
*** 18,24 
  
  # Subdirectories containing headers for server-side dev
  SUBDIRS = access bootstrap catalog commands executor lib libpq mb \
!   nodes optimizer parser port regex rewrite storage tcop utils
  
  # Install all headers
  install: all installdirs remove-old-headers
--- 18,25 
  
  # Subdirectories containing headers for server-side dev
  SUBDIRS = access bootstrap catalog commands executor lib libpq mb \
!   nodes optimizer parser port regex rewrite storage tcop utils \
!   port port/win32 port/win32/arpa port/win32/netinet port/win32/sys
  
  # Install all headers
  install: all installdirs remove-old-headers
*** ./src/makefiles/Makefile.win32.orig Thu Oct 28 08:24:17 2004
--- ./src/makefiles/Makefile.win32  Sun Nov  7 10:44:58 2004
***
*** 35,37 
--- 35,48 
  ifneq (,$(findstring src/pl/plpython,$(subdir)))
  override CPPFLAGS+= -DUSE_DL_IMPORT
  endif
+ 
+ # special win32 headers are provided here
+ ifdef PGXS
+ override CPPFLAGS+= $(includedir_server)/port/win32
+ endif
+ 
+ # it is better to install shared-libraries anyway?
+ # may be overriden with make MAKE_DLL=false install
+ ifndef MAKE_DLL
+ MAKE_DLL  = true
+ endif

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])