Re: [PATCHES] plperl warnings on win32

2007-07-25 Thread Magnus Hagander
On Tue, Jul 24, 2007 at 12:11:03PM -0400, Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > An alternative might be to provide a perl script in the tools directory > > which would fix the perl header file. > > Seems like more work than it's worth. I'm OK with Magnus' proposed > Ma

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > An alternative might be to provide a perl script in the tools directory > which would fix the perl header file. Seems like more work than it's worth. I'm OK with Magnus' proposed Makefile hack --- though someone should also complain to ActiveState so

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote: >> If you insist you can apply that in some way that makes it Windows-only. > Uh, it's already inside a win32-only block. So it'll only affect mingw. Doh ... not enough caffeine yet ... sorry f

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Andrew Dunstan
Magnus Hagander wrote: On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote: Magnus Hagander <[EMAIL PROTECTED]> writes: override CPPFLAGS += -DPLPERL_HAVE_UID_GID + # Perl on win32 contains /* within comment all over the header file, + # so disable this warning. + override CFLA

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Magnus Hagander
On Tue, Jul 24, 2007 at 10:11:52AM -0400, Andrew Dunstan wrote: > > > Magnus Hagander wrote: > >On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote: > > > >>Magnus Hagander <[EMAIL PROTECTED]> writes: > >> > >>> override CPPFLAGS += -DPLPERL_HAVE_UID_GID > >>>+ # Perl on win32 contain

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Andrew Dunstan
Magnus Hagander wrote: On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote: Magnus Hagander <[EMAIL PROTECTED]> writes: override CPPFLAGS += -DPLPERL_HAVE_UID_GID + # Perl on win32 contains /* within comment all over the header file, + # so disable this warning. + override CFLA

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Magnus Hagander
On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > override CPPFLAGS += -DPLPERL_HAVE_UID_GID > > + # Perl on win32 contains /* within comment all over the header file, > > + # so disable this warning. > > + override CFLAGS += -Wno-comment

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > override CPPFLAGS += -DPLPERL_HAVE_UID_GID > + # Perl on win32 contains /* within comment all over the header file, > + # so disable this warning. > + override CFLAGS += -Wno-comment > endif If you insist you can apply that in some way that makes i

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Andrew Dunstan
Magnus Hagander wrote: When building with MingW, we get a ton of warnings of the type: C:/Perl/lib/CORE/config.h:39:20: warning: "/*" within comment (see http://pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=vaquita&dt=2007-07-23%20200011&stg=make) Attached patch removes this by disabling the w

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Gregory Stark
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > /*#define HAS_BCMP/**/ > > The difference is in the space. This is with perl 5.8.8.819 from > ActiveState - the latest is 5.8.8.820, and I doubt they've changed > that there. Huh, I'm on 5.8.8 here as well. I suppose ActiveState has to generat

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Magnus Hagander
On Tue, Jul 24, 2007 at 12:42:38PM +0100, Gregory Stark wrote: > > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > > > When building with MingW, we get a ton of warnings of the type: > > C:/Perl/lib/CORE/config.h:39:20: warning: "/*" within comment > > > > (see > > http://pgbuildfarm.org/cgi-bin/

Re: [PATCHES] plperl warnings on win32

2007-07-24 Thread Gregory Stark
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > When building with MingW, we get a ton of warnings of the type: > C:/Perl/lib/CORE/config.h:39:20: warning: "/*" within comment > > (see > http://pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=vaquita&dt=2007-07-23%20200011&stg=make) Huh, what's actu

[PATCHES] plperl warnings on win32

2007-07-24 Thread Magnus Hagander
When building with MingW, we get a ton of warnings of the type: C:/Perl/lib/CORE/config.h:39:20: warning: "/*" within comment (see http://pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=vaquita&dt=2007-07-23%20200011&stg=make) Attached patch removes this by disabling the warning specifically for plp