Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-30 Thread Martin Zaun
Heikki Linnakangas wrote: Andrew Dunstan wrote: Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: I've been working on an improved archive_command shell script that I expect to submit for comments and potential inclusion in the documentation as a better base for other people to

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-29 Thread Heikki Linnakangas
Andrew Dunstan wrote: Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the copy is successfully completed. I think that this

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Heikki Linnakangas
Andrew Dunstan wrote: Kevin Grittner wrote: Heikki Linnakangas [EMAIL PROTECTED] wrote: We really need a more reliable way of detecting that a file has been fully copied. In our scripts we handle this by copying to a temp directory on the same mount point as the archive

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Andrew Dunstan
Heikki Linnakangas wrote: Andrew Dunstan wrote: - or maybe provide a .bat file or perl script that would work as na archive_command on Windows. We're not talking about archive_command. We're talking about the thing that copies files to the directory that pg_standby polls. Er, that's

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Heikki Linnakangas
Andrew Dunstan wrote: Heikki Linnakangas wrote: Andrew Dunstan wrote: - or maybe provide a .bat file or perl script that would work as na archive_command on Windows. We're not talking about archive_command. We're talking about the thing that copies files to the directory that pg_standby

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Greg Smith
On Wed, 23 Jul 2008, Kevin Grittner wrote: In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the copy is successfully completed. I think that this even works on Windows. Could that just be

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-28 Thread Andrew Dunstan
Greg Smith wrote: On Wed, 23 Jul 2008, Kevin Grittner wrote: In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the copy is successfully completed. I think that this even works on Windows.

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Simon Riggs
On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: reviewing your patch Current status is this: * My understanding is that Dave and Andrew (and therefore Simon) think the approach proposed

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote: I thought the latest conclusion was that changing the behavior of pg_standby itself wouldn't address the problem anyway, and that what we need is just a docs patch recommending that people use safe copying

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-25 Thread Simon Riggs
On Fri, 2008-07-25 at 16:58 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: On Fri, 2008-07-25 at 16:31 -0400, Tom Lane wrote: I thought the latest conclusion was that changing the behavior of pg_standby itself wouldn't address the problem anyway, and that what we need is

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Simon Riggs
On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: 1. Issues with applying the patch to CVS HEAD: For me, the patch applies cleanly to CVS HEAD. I do notice that there are two files standby.sgml and pgstandby.sgml. I can't see where standby.sgml comes from, but I haven't created it;

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Heikki Linnakangas
Simon Riggs wrote: On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: 8. Unresolved question of implementing now/later a cp replacement The patch implements what's been agreed. I'm not rewriting cp, for reasons already discussed. Not a comment to you Martin, but it's fairly clear that

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Kevin Grittner
Heikki Linnakangas [EMAIL PROTECTED] wrote: We really need a more reliable way of detecting that a file has been fully copied. In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory and doing a mv to the archive location when the

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Andrew Dunstan
Kevin Grittner wrote: Heikki Linnakangas [EMAIL PROTECTED] wrote: We really need a more reliable way of detecting that a file has been fully copied. In our scripts we handle this by copying to a temp directory on the same mount point as the archive directory

Re: [HACKERS][PATCHES] odd output in restore mode

2008-07-23 Thread Simon Riggs
On Wed, 2008-07-23 at 21:38 +0300, Heikki Linnakangas wrote: Simon Riggs wrote: On Tue, 2008-07-22 at 17:19 -0700, Martin Zaun wrote: 8. Unresolved question of implementing now/later a cp replacement The patch implements what's been agreed. I'm not rewriting cp, for reasons