Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-04 Thread Michael Meskes
On Sun, Sep 03, 2006 at 10:21:11PM -0400, Bruce Momjian wrote:
 When I tried the ecpg regression tests it complained there was no
 results/ directory.  I created one and it worked.

Hmm, anyone else experiencing this? The pg_regress.sh has this code that
should create it:

outputdir=results/

if [ ! -d $outputdir ]; then
mkdir -p $outputdir || { (exit 2); exit; }
fi

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org


Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-04 Thread Tom Lane
Michael Meskes [EMAIL PROTECTED] writes:
 On Sun, Sep 03, 2006 at 10:21:11PM -0400, Bruce Momjian wrote:
 When I tried the ecpg regression tests it complained there was no
 results/ directory.  I created one and it worked.

 Hmm, anyone else experiencing this? The pg_regress.sh has this code that
 should create it:

 outputdir=results/

 if [ ! -d $outputdir ]; then
 mkdir -p $outputdir || { (exit 2); exit; }
 fi

I'll bet you should lose the slash in $outputdir.  test(1) might or
might not be friendly about stripping that off.

regards, tom lane

---(end of broadcast)---
TIP 1: if posting/reading through Usenet, please send an appropriate
   subscribe-nomail command to [EMAIL PROTECTED] so that your
   message can get through to the mailing list cleanly


Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-04 Thread Bruce Momjian
Tom Lane wrote:
 Michael Meskes [EMAIL PROTECTED] writes:
  On Sun, Sep 03, 2006 at 10:21:11PM -0400, Bruce Momjian wrote:
  When I tried the ecpg regression tests it complained there was no
  results/ directory.  I created one and it worked.
 
  Hmm, anyone else experiencing this? The pg_regress.sh has this code that
  should create it:
 
  outputdir=results/
 
  if [ ! -d $outputdir ]; then
  mkdir -p $outputdir || { (exit 2); exit; }
  fi
 
 I'll bet you should lose the slash in $outputdir.  test(1) might or
 might not be friendly about stripping that off.

Yep, I saw this error:

mkdir: results/: No such file or directory
gmake: *** [installcheck] Error 2

I have removed the trailing slash from CVS;  tests run fine now. 
Thanks.

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 6: explain analyze is your friend


Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-03 Thread Tom Lane
Michael Glaesemann [EMAIL PROTECTED] writes:
 On Sep 4, 2006, at 9:41 , Tom Lane wrote:
 This patch fails to apply --- looks like whitespace got mangled in
 transit.  Please resend as an attachment.

 Please let me know if you have any problems with this one.

Ah, that one works --- applied.  A few comments:

* You worried about the tmask coding in your original message, but
I think that's OK as-is.  The point of that code, IIUC, is to reject
multiple specifications of the same field type, eg '1 day 2 days'.
If we changed it then we'd reject '1.5 month 2 days', whereas I think
least surprise would dictate adding the components to give 1 month
17 days.

* AFAICT the ecpg regression tests are not affected by this change.

* You mentioned being unable to get the ecpg tests to run on your
machine.  I'm sure Michael and Joachim would like the details.  The
ecpg regression tests are pretty new and some portability problems
are to be expected, but they seem to be passing on all the machines
Michael and Joachim and I have access to.

regards, tom lane

---(end of broadcast)---
TIP 6: explain analyze is your friend


Re: [HACKERS] [PATCHES] Interval month, week - day

2006-09-03 Thread Andrew Dunstan



Tom Lane wrote:

You mentioned being unable to get the ecpg tests to run on your
machine.  I'm sure Michael and Joachim would like the details.  The
ecpg regression tests are pretty new and some portability problems
are to be expected, but they seem to be passing on all the machines
Michael and Joachim and I have access to.


  


I have just today released a new version of the buildfarm client that 
includes ECPG regression testing for HEAD (until now that was in our CVS 
tip but not in a released version).


cheers

andrew

---(end of broadcast)---
TIP 4: Have you searched our list archives?

  http://archives.postgresql.org