Alvaro Herrera [EMAIL PROTECTED] writes:
What about arranging postmaster's main loop so that it starts the stats
collector process if one of the options is activated (assuming they were
all off at start)? Right now you have to restart the server, but I
don't see why it has to be like that.
Tom Lane wrote:
Actually, this entire thread is based on a misconception: the bug
reporter was under the misimpression that the sum total of what the
collector does is described by the three suboptions, and so having
start_collector on without any of the suboptions on is a useless state.
But
Bruce Momjian pgman@candle.pha.pa.us writes:
My issue is that we usually don't have GUC variables that can be set
automatically. Why can't we have the stats collector try to start, and
just throw a server log message if it fails.
I still say the code is not broken and does not require fixing.
Bruce Momjian pgman@candle.pha.pa.us writes:
The following patch removes the GUC stats_start_collector. The stats
process is now always started.
WAIT a second!!!
That was *not* the agenda; the collector is only supposed to start if
you turn on at least one of the collection options.
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
Later such as in a later postmaster start, but personally I would just
remove the option completely.
I don't have a problem with removing it as a writable option ... but
I'm thinking we should leave it as a read-only GUC
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
The following patch removes the GUC stats_start_collector. The stats
process is now always started.
WAIT a second!!!
That was *not* the agenda; the collector is only supposed to start if
you turn on at least one of the
Bruce Momjian pgman@candle.pha.pa.us writes:
The current default is true, meaning it always started.
*By default* it starts. But you can turn it off, and there was no
discussion of removing that option.
regards, tom lane
---(end of
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
The current default is true, meaning it always started.
*By default* it starts. But you can turn it off, and there was no
discussion of removing that option.
I thought we agreed that there was little value in allowing someone to
On Mon, Jun 27, 2005 at 08:51:46PM -0400, Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
The following patch removes the GUC stats_start_collector. The stats
process is now always started.
WAIT a second!!!
That was *not* the agenda; the
Alvaro Herrera wrote:
On Mon, Jun 27, 2005 at 08:51:46PM -0400, Bruce Momjian wrote:
Tom Lane wrote:
Bruce Momjian pgman@candle.pha.pa.us writes:
The following patch removes the GUC stats_start_collector. The stats
process is now always started.
WAIT a second!!!
That
On Mon, Jun 27, 2005 at 09:13:20PM -0400, Bruce Momjian wrote:
Alvaro Herrera wrote:
In fact, if it wasn't started from the beginning, we couldn't enable
query strings without restarting the server.
That's true -- if you start with the collector disabled, you can't
enable query
Alvaro Herrera [EMAIL PROTECTED] writes:
What about arranging postmaster's main loop so that it starts the stats
collector process if one of the options is activated (assuming they were
all off at start)? Right now you have to restart the server, but I
don't see why it has to be like that.
12 matches
Mail list logo
