Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8 encoding

2005-12-22 Thread Tatsuo Ishii
Tom Lane wrote: Tatsuo Ishii [EMAIL PROTECTED] writes: It looks like somebody rearranged the pg_enc enum without bothering to fix the tables that are affected by this. I will look into this. Thank you. It might be worth adding a comment to pg_wchar.h listing all the places

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8 encoding conversion

2005-12-22 Thread Bruce Momjian
That is a nice solution --- instead of listing all the encodings, you listed just the ones that need to be used. The list is shorter and clearer. It seems like the right approach. Thanks. --- Tatsuo Ishii wrote: Tom

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8 encoding

2005-12-22 Thread Tom Lane
Tatsuo Ishii [EMAIL PROTECTED] writes: I think the current implementaion in utf8_and_iso8859.c is fast but too fragile against rearranging of encoding id. I modify those functions in utf8_and_iso8859.c to do a linear search with encoding id. That's not unreasonable, but I was wondering whether

Re: [PATCHES] [BUGS] BUG #2120: Crash when doing UTF8-ISO_8859_8 encoding conversion

2005-12-21 Thread Bruce Momjian
Tom Lane wrote: Tatsuo Ishii [EMAIL PROTECTED] writes: It looks like somebody rearranged the pg_enc enum without bothering to fix the tables that are affected by this. I will look into this. Thank you. It might be worth adding a comment to pg_wchar.h listing all the places that need