Re: [PATCHES] [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch

2007-09-26 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: [ revised version of tuptoaster-fixup.patch ] I've applied most of this. I didn't like the hardwired assumption about minimum size to compress, and anyway you had put it in a place where it broke the intended behavior for SET STORAGE PLAIN. I replaced it

Re: [PATCHES] [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch

2007-07-27 Thread Gregory Stark
Sorry, meant to send the previous message to pgsql-patches. Here's a version cut using cvs diff so it's usable with -p0 I added one more fixup. There was a silly test in toast_fetch_datum_slice() which handled compressed datums. Returning a slice of a compressed datum is nonsensical with toast