Re: [PATCHES] [HACKERS] Inefficiency in recent pgtz patch

2005-06-14 Thread Bruce Momjian

Patch applied.  Thanks.

---

Magnus Hagander wrote:
> >> Do you agree that using a hashtable for it in general is a good idea
> >> assuming this sideeffect is removed, though?
> >
> >I have no problem with the hashtable, only with preloading it with
> >everything.  What I'd like to see is that the table inherited at fork()
> >contains just the data for the default timezone.  (At least in the
> >normal case where that setting hasn't been changed since postmaster
> >start.)
> 
> Here's a patch doing this. Changes score_timezone not to use pg_tzset(),
> and thus not loading all the zones in the cache. The actual timezone
> being picked will be set using set_global_timezone() which in turn calls
> pg_tzset() and loads it in the cache.
> 
> 
> //Magnus

Content-Description: tzcache.patch

[ Attachment, skipping... ]

> 
> ---(end of broadcast)---
> TIP 7: don't forget to increase your free space map settings

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  pgman@candle.pha.pa.us   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])


Re: [PATCHES] [HACKERS] Inefficiency in recent pgtz patch

2005-06-04 Thread Magnus Hagander
>> Do you agree that using a hashtable for it in general is a good idea
>> assuming this sideeffect is removed, though?
>
>I have no problem with the hashtable, only with preloading it with
>everything.  What I'd like to see is that the table inherited at fork()
>contains just the data for the default timezone.  (At least in the
>normal case where that setting hasn't been changed since postmaster
>start.)

Here's a patch doing this. Changes score_timezone not to use pg_tzset(),
and thus not loading all the zones in the cache. The actual timezone
being picked will be set using set_global_timezone() which in turn calls
pg_tzset() and loads it in the cache.


//Magnus


tzcache.patch
Description: tzcache.patch

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings