Robert Treat wrote:
> On Thursday 16 February 2006 00:27, Tom Lane wrote:
> > Robert Treat <[EMAIL PROTECTED]> writes:
> > > As stated, the following patch adds a list of patch submission guidelines
> > > based on Simon Riggs suggestions to the developers FAQ.
> >
> > A couple minor comments ...
>
Tom Lane wrote:
> Robert Treat <[EMAIL PROTECTED]> writes:
> > On Thursday 16 February 2006 00:27, Tom Lane wrote:
> >> * avoid unnecessary whitespace changes. They just distract the
> >> reviewer, and your formatting changes will probably not survive
> >> the next pgindent run anyway.
>
> > woul
Tom Lane wrote:
> > ! The patch should be generated in contextual diff format and
> > should
> > ! be applicable from the root directory. If you are unfamiliar
> > with
> > ! this, you might find the script
> > src/tools/makediff/difforig
> > ! useful.
On Thu, 2006-02-16 at 15:09 -0500, Robert Treat wrote:
> On Thursday 16 February 2006 00:27, Tom Lane wrote:
> > Robert Treat <[EMAIL PROTECTED]> writes:
> > > As stated, the following patch adds a list of patch submission guidelines
> > > based on Simon Riggs suggestions to the developers FAQ.
> >
On Thursday 16 February 2006 00:27, Tom Lane wrote:
> Robert Treat <[EMAIL PROTECTED]> writes:
> > As stated, the following patch adds a list of patch submission guidelines
> > based on Simon Riggs suggestions to the developers FAQ.
>
> A couple minor comments ...
>
Attached patch updated based on
Robert Treat <[EMAIL PROTECTED]> writes:
> On Thursday 16 February 2006 00:27, Tom Lane wrote:
>> * avoid unnecessary whitespace changes. They just distract the
>> reviewer, and your formatting changes will probably not survive
>> the next pgindent run anyway.
> would diff -c --ignore-space-chang
On Thursday 16 February 2006 00:27, Tom Lane wrote:
> Robert Treat <[EMAIL PROTECTED]> writes:
> > ! The patch should be generated in contextual diff format and
> > should !be applicable from the root directory. If you are
> > unfamiliar
> > with ! this, you migh
Robert Treat <[EMAIL PROTECTED]> writes:
> As stated, the following patch adds a list of patch submission guidelines
> based on Simon Riggs suggestions to the developers FAQ.
A couple minor comments ...
> ! Ensure that your patch is generated against the most recent
> version
> !
On Tuesday 14 February 2006 20:42, Robert Treat wrote:
> On Tuesday 14 February 2006 16:00, Martijn van Oosterhout wrote:
> > > I would like to suggest that we increase substantially the FAQ entries
> > > relating to patch submission. By we, I actually mean please could the
> > > committers sit dow
