Re: [PATCHES] [HACKERS] Userset logging

2008-08-22 Thread Bruce Momjian
Simon Riggs wrote:
> 
> On Mon, 2008-07-07 at 16:13 +0100, Simon Riggs wrote:
> > I notice log_temp_files is a PGC_USERSET parameter, which is out of step
> > with our current thinking on who is allowed to initiate logging.
> > 
> > Is there a rationale for this? Or should we set this to PGC_SUSET like
> > all the other logging functions?
> 
> Patch enclosed.

Patch applied, docs updated.

-- 
  Bruce Momjian  <[EMAIL PROTECTED]>http://momjian.us
  EnterpriseDB http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches


Re: [PATCHES] [HACKERS] Userset logging

2008-07-08 Thread Simon Riggs

On Mon, 2008-07-07 at 16:13 +0100, Simon Riggs wrote:
> I notice log_temp_files is a PGC_USERSET parameter, which is out of step
> with our current thinking on who is allowed to initiate logging.
> 
> Is there a rationale for this? Or should we set this to PGC_SUSET like
> all the other logging functions?

Patch enclosed.

-- 
 Simon Riggs   www.2ndQuadrant.com
 PostgreSQL Training, Services and Support
Index: src/backend/utils/misc/guc.c
===
RCS file: /home/sriggs/pg/REPOSITORY/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.461
diff -c -r1.461 guc.c
*** src/backend/utils/misc/guc.c	1 Jul 2008 21:07:33 -	1.461
--- src/backend/utils/misc/guc.c	8 Jul 2008 06:03:18 -
***
*** 1861,1867 
  	},
  
  	{
! 		{"log_temp_files", PGC_USERSET, LOGGING_WHAT,
  			gettext_noop("Log the use of temporary files larger than this number of kilobytes."),
  			gettext_noop("Zero logs all files. The default is -1 (turning this feature off)."),
  			GUC_UNIT_KB
--- 1861,1867 
  	},
  
  	{
! 		{"log_temp_files", PGC_SUSET, LOGGING_WHAT,
  			gettext_noop("Log the use of temporary files larger than this number of kilobytes."),
  			gettext_noop("Zero logs all files. The default is -1 (turning this feature off)."),
  			GUC_UNIT_KB

-- 
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches