Re: [PATCHES] [HACKERS] enum types and binary queries

2007-09-04 Thread Andrew Dunstan
Merlin Moncure wrote: On 8/31/07, Tom Lane <[EMAIL PROTECTED]> wrote: Andrew Dunstan <[EMAIL PROTECTED]> writes: Here's a patch (minus catalog bump) which I think does that. Looks sane in a very quick once-over, but I didn't test it. works fine (here was my test). thank

Re: [PATCHES] [HACKERS] enum types and binary queries

2007-08-31 Thread Merlin Moncure
On 8/31/07, Merlin Moncure <[EMAIL PROTECTED]> wrote: > On 8/31/07, Tom Lane <[EMAIL PROTECTED]> wrote: > > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > > Here's a patch (minus catalog bump) which I think does that. > > > > Looks sane in a very quick once-over, but I didn't test it. > > works fin

Re: [PATCHES] [HACKERS] enum types and binary queries

2007-08-31 Thread Merlin Moncure
On 8/31/07, Tom Lane <[EMAIL PROTECTED]> wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: > > Here's a patch (minus catalog bump) which I think does that. > > Looks sane in a very quick once-over, but I didn't test it. works fine (here was my test). thanks for quick resolution to this issue. st

Re: [PATCHES] [HACKERS] enum types and binary queries

2007-08-31 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Here's a patch (minus catalog bump) which I think does that. Looks sane in a very quick once-over, but I didn't test it. regards, tom lane ---(end of broadcast)--- TIP 7: You can

Re: [PATCHES] [HACKERS] enum types and binary queries

2007-08-31 Thread Andrew Dunstan
Tom Lane wrote: Andrew's idea of using the enum ordinal value would meet that test, but at least with the current layout of pg_enum it would be quite expensive to do the conversion in either direction --- you'd have to fetch multiple catalog rows. I think we'd have to add another column showi