Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Andrew Dunstan wrote: Here are some options: 1. change the type of log_statement option from boolean to string, with allowed values of all, mod, ddl, none with default none. 2. same as 1. but make boolean true values synonyms for all and boolean false values synonyms for none. 3. keep

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Andrew Dunstan
Unless I'm missing something, this patch has the effect that with values of ddl or mod for log_statement, a statement with a parse error will not be logged, which was what I hoped to avoid. cheers andrew Bruce Momjian wrote: Andrew Dunstan wrote: Here are some options: 1. change the

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Andrew Dunstan wrote: Unless I'm missing something, this patch has the effect that with values of ddl or mod for log_statement, a statement with a parse error will not be logged, which was what I hoped to avoid. Right. The query type can't be determined during a syntax error because the

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Unless I'm missing something, this patch has the effect that with values of ddl or mod for log_statement, a statement with a parse error will not be logged, which was what I hoped to avoid. Right. The query type can't be determined during a

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Bruce Momjian wrote: Andrew Dunstan wrote: Unless I'm missing something, this patch has the effect that with values of ddl or mod for log_statement, a statement with a parse error will not be logged, which was what I hoped to avoid.

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Andrew Dunstan wrote: Bruce Momjian wrote: Andrew Dunstan wrote: Unless I'm missing something, this patch has the effect that with values of ddl or mod for log_statement, a statement with a parse error will not be logged, which was what I hoped to avoid. Right. The

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Andrew Dunstan wrote: However, I think with a little extra work it might be possible to have both. Right now, the way it is done, only a real syntax error skips logging. If you referenced an invalid table or something, it does print the log just before the invalid table name mention.

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Andrew Dunstan
Bruce Momjian wrote: Right now we have log_min_error_statement: #log_min_error_statement = panic # Values in order of increasing severity: # debug5, debug4, debug3, debug2, debug1, # info,

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Andrew Dunstan wrote: Bruce Momjian wrote: Right now we have log_min_error_statement: #log_min_error_statement = panic # Values in order of increasing severity: # debug5, debug4, debug3, debug2, debug1,

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Bruce Momjian wrote: Right now we have log_min_error_statement: #log_min_error_statement = panic # Values in order of increasing severity: # debug5, debug4, debug3, debug2, debug1,

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Andrew Dunstan wrote: I think I'd prefer that to having it tied to the log_min_error_statement level. But I don't care that much. OK, at least we understand each other. Right now we don't have any special syntax error log processing. We have errors logged through

Re: [PATCHES] [HACKERS] logging statement levels

2004-04-06 Thread Bruce Momjian
Patch applied. --- Bruce Momjian wrote: Andrew Dunstan wrote: Here are some options: 1. change the type of log_statement option from boolean to string, with allowed values of all, mod, ddl, none with default