Re: [PATCHES] [HACKERS] msvc and vista fun
On Mon, Jun 25, 2007 at 03:19:32PM -0400, Andrew Dunstan wrote: > > > I wrote: > > > > > >Would making a change like this in those 12 places be so ugly? > > > > Specifically, I propose the following patch, which should fix the issues > buildfarm apparently has with the XP command shell (or some incarnations > of it). Yeah. Dave has verified taht it's actually because of the XP stuff (he can repro the failure on XP), so I guess we don't have much choice. > Strictly speaking, we don't need the changes in builddoc.bat and > install.bat, but I did them for the sake of completeness. Since it > should not affect anyone not setting XP_EXIT_FIX it seems fairly low risk. I've applied it, except for builddoc.bat. Since we didn't send out an exitcode anyway there, it makes no difference. Left them in install.bat because there's an actual exitcode there. //Magnus ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster
Re: [PATCHES] [HACKERS] msvc and vista fun
Magnus Hagander wrote: Andrew Dunstan wrote: I wrote: Would making a change like this in those 12 places be so ugly? Specifically, I propose the following patch, which should fix the issues buildfarm apparently has with the XP command shell (or some incarnations of it). Strictly speaking, we don't need the changes in builddoc.bat and install.bat, but I did them for the sake of completeness. Since it should not affect anyone not setting XP_EXIT_FIX it seems fairly low risk. Yeah. I still would like to have it confirmed that this is actually an XP fault, and not something else in your environment. To that end, I've bugged Dave to run some builds on his XP VM (since it apparently works fine on my XP x64 machine). Ok. FWIW, this box is extremely clean and up to date. And I had the identical issue on my previous XP/x386 box. It would be very strange if somehow two environments got polluted like this. cheers andrew ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [PATCHES] [HACKERS] msvc and vista fun
Andrew Dunstan wrote: > > > I wrote: >> >> >> Would making a change like this in those 12 places be so ugly? >> > > Specifically, I propose the following patch, which should fix the issues > buildfarm apparently has with the XP command shell (or some incarnations > of it). > > Strictly speaking, we don't need the changes in builddoc.bat and > install.bat, but I did them for the sake of completeness. Since it > should not affect anyone not setting XP_EXIT_FIX it seems fairly low risk. Yeah. I still would like to have it confirmed that this is actually an XP fault, and not something else in your environment. To that end, I've bugged Dave to run some builds on his XP VM (since it apparently works fine on my XP x64 machine). //magnus ---(end of broadcast)--- TIP 6: explain analyze is your friend
