Re: [PATCHES] [HACKERS] obj_description problems?

[Christopher Kings-Lynne]

I checked them all before applying, but please do cross-check.  We're
close enough to release that double- and triple-checking patches is
called for.
Checked them a bit - nothing too exhaustive.

Chris



---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [PATCHES] [HACKERS] obj_description problems?

[Tom Lane]

Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
> OK, I will test them all today and get back to you.

I checked them all before applying, but please do cross-check.  We're
close enough to release that double- and triple-checking patches is
called for.

regards, tom lane

---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [PATCHES] [HACKERS] obj_description problems?

[Christopher Kings-Lynne]

Reviewed, tested, applied.
Thanks.

maybe should test all the other qualified functions?


What other qualified functions?  There might possibly be some issues in
contrib stuff, but there are no other SQL-language functions defined in
the main system (except information_schema, which we already checked).
Sorry - I meant "other functions that are now properly qualified in my 
patch".  ie, you have already tested them.

Chris

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
 joining column's datatypes do not match

Re: [PATCHES] [HACKERS] obj_description problems?

[Christopher Kings-Lynne]

*sigh* - it's really not my day today.  Attached is patch that actually 
compiles and fixes the problem.  We will need to bump CATVERSION, and 
maybe should test all the other qualified functions?
I think you've identified a real issue, but how many of these modified
functions did you actually test?  I thought SUBSTRING was a reserved
word, for example ...
Well, some...  I did run the regression tests and they passed, but I 
assumed that they would call all of the functions.

OK, I will test them all today and get back to you.

Chris



---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] [HACKERS] obj_description problems?

[Tom Lane]

Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
> *sigh* - it's really not my day today.  Attached is patch that actually 
> compiles and fixes the problem.  We will need to bump CATVERSION, and 

Reviewed, tested, applied.

> maybe should test all the other qualified functions?

What other qualified functions?  There might possibly be some issues in
contrib stuff, but there are no other SQL-language functions defined in
the main system (except information_schema, which we already checked).

regards, tom lane

---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [PATCHES] [HACKERS] obj_description problems?

[Tom Lane]

Christopher Kings-Lynne <[EMAIL PROTECTED]> writes:
> *sigh* - it's really not my day today.  Attached is patch that actually 
> compiles and fixes the problem.  We will need to bump CATVERSION, and 
> maybe should test all the other qualified functions?

I think you've identified a real issue, but how many of these modified
functions did you actually test?  I thought SUBSTRING was a reserved
word, for example ...

regards, tom lane

---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings

Re: [PATCHES] [HACKERS] obj_description problems?

[Christopher Kings-Lynne]

*sigh* - it's really not my day today.  Attached is patch that actually 
compiles and fixes the problem.  We will need to bump CATVERSION, and 
maybe should test all the other qualified functions?

Chris


Index: src/include/catalog/pg_proc.h
===
RCS file: /projects/cvsroot/pgsql-server/src/include/catalog/pg_proc.h,v
retrieving revision 1.313
diff -c -r1.313 pg_proc.h
*** src/include/catalog/pg_proc.h   17 Aug 2003 19:58:06 -  1.313
--- src/include/catalog/pg_proc.h   21 Oct 2003 05:47:52 -
***
*** 1477,1483 
  DESCR("convert abstime to timestamp with time zone");
  DATA(insert OID = 1174 (  timestamptzPGNSP PGUID 12 f f t f s 1 1184 "1082"  
date_timestamptz - _null_ ));
  DESCR("convert date to timestamp with time zone");
! DATA(insert OID = 1176 (  timestamptzPGNSP PGUID 14 f f t f s 2 1184 "1082 1083" 
 "select timestamptz($1 + $2)" - _null_ ));
  DESCR("convert date and time to timestamp with time zone");
  DATA(insert OID = 1177 (  interval   PGNSP PGUID 12 f f t f i 1 1186 
"703"reltime_interval - _null_ ));
  DESCR("convert reltime to interval");
--- 1477,1483 
  DESCR("convert abstime to timestamp with time zone");
  DATA(insert OID = 1174 (  timestamptzPGNSP PGUID 12 f f t f s 1 1184 "1082"  
date_timestamptz - _null_ ));
  DESCR("convert date to timestamp with time zone");
! DATA(insert OID = 1176 (  timestamptzPGNSP PGUID 14 f f t f s 2 1184 "1082 1083" 
 "select pg_catalog.timestamptz($1 + $2)" - _null_ ));
  DESCR("convert date and time to timestamp with time zone");
  DATA(insert OID = 1177 (  interval   PGNSP PGUID 12 f f t f i 1 1186 
"703"reltime_interval - _null_ ));
  DESCR("convert reltime to interval");
***
*** 1520,1528 
  DATA(insert OID = 1200 (  intervalPGNSP PGUID 12 f f t f i 2 
1186 "1186 23"   interval_scale - _null_ ));
  DESCR("adjust interval precision");
  
! DATA(insert OID = 1215 (  obj_description PGNSP PGUID 14 f f t f s 2  25 "26 
19"  "select description from pg_description where objoid = $1 and classoid = 
(select oid from pg_class where relname = $2 and relnamespace = PGNSP) and objsubid = 
0" - _null_ ));
  DESCR("get description for object id and catalog name");
! DATA(insert OID = 1216 (  col_description PGNSP PGUID 14 f f t f s 2  25 "26 
23"  "select description from pg_description where objoid = $1 and classoid = 
\'pg_catalog.pg_class\'::regclass and objsubid = $2" - _null_ ));
  DESCR("get description for table column");
  
  DATA(insert OID = 1217 (  date_trunc PGNSP PGUID 12 f f t f i 2 1184 "25 1184"   
 timestamptz_trunc - _null_ ));
--- 1520,1528 
  DATA(insert OID = 1200 (  intervalPGNSP PGUID 12 f f t f i 2 
1186 "1186 23"   interval_scale - _null_ ));
  DESCR("adjust interval precision");
  
! DATA(insert OID = 1215 (  obj_description PGNSP PGUID 14 f f t f s 2  25 "26 
19"  "select description from pg_catalog.pg_description where objoid = $1 and 
classoid = (select oid from pg_catalog.pg_class where relname = $2 and relnamespace = 
PGNSP) and objsubid = 0" - _null_ ));
  DESCR("get description for object id and catalog name");
! DATA(insert OID = 1216 (  col_description PGNSP PGUID 14 f f t f s 2  25 "26 
23"  "select description from pg_catalog.pg_description where objoid = $1 and 
classoid = \'pg_catalog.pg_class\'::regclass and objsubid = $2" - _null_ ));
  DESCR("get description for table column");
  
  DATA(insert OID = 1217 (  date_trunc PGNSP PGUID 12 f f t f i 2 1184 "25 1184"   
 timestamptz_trunc - _null_ ));
***
*** 1683,1689 
   * This form of obj_description is now deprecated, since it will fail if
   * OIDs are not unique across system catalogs.Use the other forms instead.
   */
! DATA(insert OID = 1348 (  obj_description  PGNSP PGUID 14 f f t f s 1 25 "26"  
"select description from pg_description where objoid = $1 and objsubid = 0" - _null_ 
));
  DESCR("get description for object id (deprecated)");
  DATA(insert OID = 1349 (  oidvectortypes   PGNSP PGUID 12 f f t f s 1 25 "30"  
oidvectortypes - _null_ ));
  DESCR("print type names of oidvector field");
--- 1683,1689 
   * This form of obj_description is now deprecated, since it will fail if
   * OIDs are not unique across system catalogs.Use the other forms instead.
   */
! DATA(insert OID = 1348 (  obj_description  PGNSP PGUID 14 f f t f s 1 25 "26"  
"select description from pg_catalog.pg_description where objoid = $1 and objsubid = 0" 
- _null_ ));
  DESCR("get description for object id (deprecated)");
  DATA(insert OID = 1349 (  oidvectortypes   PGNSP PGUID 12 f f t f s 1 25 "30"  
oidvectortypes - _null_ ));
  DESCR("print type names of oidvector field");
***
*** 1740,1754 
  DATA(insert OID = 1381 (  char_lengthPGNSP PGUID 1