Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 3)

2007-04-07 Thread Bruce Momjian
Updated patch applied. Thanks. I added a mention of the old syntax at the bottom of the CLUSTER manual page, and cleaned up the grammar a little. Also did a little comment cleaning in gram.y. --- Holger Schurig wrote: >

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Tom Lane
Holger Schurig <[EMAIL PROTECTED]> writes: > I agree that the example should be re-written. But I'm not sure if I need > to have a paragraph about the old syntax. There are two reasons: > - I haven't seen any other SQL command where an old syntax was > documented If we were deprecating the old s

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 3)

2007-03-29 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Ho

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Bruce Momjian
Holger Schurig wrote: > > FYI, this is a great example of valuable patch review. > > It would have been better if the TODO entry would have > been rigth :-) It was right when I wrote it. ;-) I have updated it now. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us Enterprise

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Holger Schurig
> We still need to document the old syntax, especially if we don't change > the example as well. I agree that the example should be re-written. But I'm not sure if I need to have a paragraph about the old syntax. There are two reasons: - I haven't seen any other SQL command where an old syntax w

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Holger Schurig
> FYI, this is a great example of valuable patch review. It would have been better if the TODO entry would have been rigth :-) ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.pos

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Bruce Momjian
FYI, this is a great example of valuable patch review. --- Heikki Linnakangas wrote: > Holger Schurig wrote: > > Index: src/doc/src/sgml/ref/cluster.sgml > > ==

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Heikki Linnakangas
Holger Schurig wrote: Index: src/doc/src/sgml/ref/cluster.sgml === *** src.orig/doc/src/sgml/ref/cluster.sgml 2007-03-28 23:02:12.0 +0200 --- src/doc/src/sgml/ref/cluster.sgml 2007-03-28 23:03:14.0 +0200 *

Re: [PATCHES] [PATCH] add CLUSTER table USING index

2007-03-28 Thread Holger Schurig
> Huh? You're right. I should have done a "quilt refresh -c" before re-posting the patch. ---(end of broadcast)--- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes d

Re: [PATCHES] [PATCH] add CLUSTER table USING index

2007-03-28 Thread Alvaro Herrera
FWIW you don't need to patch the TODO files. They will be updated by Bruce. (And in any case we don't remove the entries, but rather mark them with a "-" meaning "done for the next release"). Also, sql_help.h is a generated file. You need to change the appropiate SGML source (doc/src/sgml/ref/c