Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Heikki Linnakangas
Holger Schurig wrote: Index: src/doc/src/sgml/ref/cluster.sgml === *** src.orig/doc/src/sgml/ref/cluster.sgml 2007-03-28 23:02:12.0 +0200 --- src/doc/src/sgml/ref/cluster.sgml 2007-03-28 23:03:14.0 +0200

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Bruce Momjian
FYI, this is a great example of valuable patch review. --- Heikki Linnakangas wrote: Holger Schurig wrote: Index: src/doc/src/sgml/ref/cluster.sgml ===

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Holger Schurig
FYI, this is a great example of valuable patch review. It would have been better if the TODO entry would have been rigth :-) ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Holger Schurig
We still need to document the old syntax, especially if we don't change the example as well. I agree that the example should be re-written. But I'm not sure if I need to have a paragraph about the old syntax. There are two reasons: - I haven't seen any other SQL command where an old syntax

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Bruce Momjian
Holger Schurig wrote: FYI, this is a great example of valuable patch review. It would have been better if the TODO entry would have been rigth :-) It was right when I wrote it. ;-) I have updated it now. -- Bruce Momjian [EMAIL PROTECTED] http://momjian.us EnterpriseDB

Re: [PATCHES] [PATCH] add CLUSTER table USING index (take 2)

2007-03-29 Thread Tom Lane
Holger Schurig [EMAIL PROTECTED] writes: I agree that the example should be re-written. But I'm not sure if I need to have a paragraph about the old syntax. There are two reasons: - I haven't seen any other SQL command where an old syntax was documented If we were deprecating the old syntax