Re: [PATCHES] [patch] 7.4 initdb - drop trailing slash from $PGDATA

2004-01-19 Thread Andrew Dunstan
Tom Lane said:
> Peter Eisentraut <[EMAIL PROTECTED]> writes:
>> Jari Aalto wrote:
>>> I made a mistake while running 7.4 under W2k/Cygwin, so perhaps the
>>> patch would give user a little more comfort.
>
>> I don't see how.  Please explain.
>
> CVS-tip initdb seems to be written to suppress any trailing slash in
> the PGDATA path already, so this discussion may be moot.
>

Yes (except that leading slashes are not suppressed). That was deliberate,
for the sake of simplicity and clarity. It has just occurred to me though
that this might have unintended (bad) consequences on Windows if PGDATA is
set to the root of a mapped drive, like "I:/". I will think about that a
little and submit a patch if necessary.

cheers

andrew



---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] [patch] 7.4 initdb - drop trailing slash from $PGDATA

2004-01-18 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Jari Aalto wrote:
>> I made a mistake while running 7.4 under W2k/Cygwin, so perhaps
>> the patch would give user a little more comfort.

> I don't see how.  Please explain.

CVS-tip initdb seems to be written to suppress any trailing slash in
the PGDATA path already, so this discussion may be moot.

regards, tom lane

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


Re: [PATCHES] [patch] 7.4 initdb - drop trailing slash from $PGDATA

2004-01-18 Thread Peter Eisentraut
Jari Aalto wrote:
> I made a mistake while running 7.4 under W2k/Cygwin, so perhaps
> the patch would give user a little more comfort.

I don't see how.  Please explain.


---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster