Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-08 Thread Neil Conway
On Thu, 2004-10-07 at 15:15, Neil Conway wrote: > Indeed, that is true -- that's the better fix IMHO. Barring any > objections I'll commit this fix before end-of-day today. Patch applied -- apologies for the delay. -Neil ---(end of broadcast)---

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-07 Thread Neil Conway
On Thu, 2004-10-07 at 13:46, Tom Lane wrote: > [ eyeballs that... ] So a much simpler fix for Ingo's complaint would > be to move the default settings of PROMPT1 et al (lines 303-306) to the > vicinity of line 141. Indeed, that is true -- that's the better fix IMHO. Barring any objections I'll co

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Neil Conway
On Thu, 2004-10-07 at 13:05, Tom Lane wrote: > I'm just wondering if the fix is in the right place. Doesn't the same > issue arise for other variables? Well, we don't manually set other variables in psql itself, with the exception of defining some default values before we process command-line arg

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Thu, 2004-10-07 at 13:05, Tom Lane wrote: >> I'm just wondering if the fix is in the right place. Doesn't the same >> issue arise for other variables? > Well, we don't manually set other variables in psql itself, with the > exception of defining some d

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Thu, 2004-10-07 at 10:04, Ingo van Lil wrote: >> I wrote a tiny patch to prevent psql from overwriting the PROMPT[1-3] >> variables with default values after parsing the command line. > Looks good to me. Does anyone object to applying this for 8.0? I'm

Re: [PATCHES] [psql] Setting the PROMPT on command line

2004-10-06 Thread Neil Conway
On Thu, 2004-10-07 at 10:04, Ingo van Lil wrote: > I wrote a tiny patch to prevent psql from overwriting the PROMPT[1-3] > variables with default values after parsing the command line. Looks good to me. Does anyone object to applying this for 8.0? -Neil ---(end of broad