Re: [PATCHES] ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)

2008-04-24 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > The attached patch resolves the bug reported by Kaloyan Iliev [1] on -general. Applied as two separate patches (bug fix and inessential cleanup). The bug turns out to date back to the original addition of support for ALTER ... ADD COLUMN ... DEFAULT/NOT

Re: [PATCHES] ADD COLUMN with PRIMARY KEY bug (was: I think this is a BUG?)

2008-04-24 Thread Tom Lane
"Brendan Jurd" <[EMAIL PROTECTED]> writes: > I realised that there's no reason for preparing a separate SetNotNull > subcommand anymore, now that ATExecAddColumn takes care of enforcing > the constraint, so I removed this special case. This part seems to me to be code beautification, not a bug-fix