Re: [PATCHES] Allow the identifier length to be increased via

[Bruce Momjian]

Dhanaraj M wrote:
 Tom Lane wrote:
  Alvaro Herrera [EMAIL PROTECTED] writes:

  Dhanaraj M wrote:
  
  I am sending the patch for the following TODO item:
  Allow the identifier length to be increased via a configure option

 

  You should use pg_config.h, not mangle postgres_ext.h like that.  Or
  maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but
  I wouldn't do that, really).
  
 
  I'm wondering how this got into the TODO list.  It seems rather
  pointless, and likely to create client compatibility problems (if not,
  why is NAMEDATALEN exported at all?)

 Will this TODO item be removed from the list?
 Or I shall proceed with the suggestions given.

TODO item removed.

-- 
  Bruce Momjian   [EMAIL PROTECTED]
  EnterpriseDBhttp://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq

Re: [PATCHES] Allow the identifier length to be increased via a

[Dhanaraj M]

Tom Lane wrote:

Alvaro Herrera [EMAIL PROTECTED] writes:
  

Dhanaraj M wrote:


I am sending the patch for the following TODO item:
Allow the identifier length to be increased via a configure option
  


  

You should use pg_config.h, not mangle postgres_ext.h like that.  Or
maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but
I wouldn't do that, really).



I'm wondering how this got into the TODO list.  It seems rather
pointless, and likely to create client compatibility problems (if not,
why is NAMEDATALEN exported at all?)
  

Will this TODO item be removed from the list?
Or I shall proceed with the suggestions given.

Thanks
Dhanaraj

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
  choose an index scan if your joining column's datatypes do not
  match

Re: [PATCHES] Allow the identifier length to be increased via a configure option

[Alvaro Herrera]

Dhanaraj M wrote:
 I am sending the patch for the following TODO item:
 Allow the identifier length to be increased via a configure option
 
 During the configuration time, the user can set the identifier length.
 ./configure.txt --with-identlen=128
 
 However, I am not clear about the requirement.
 Can somebody review and comment on this?

You should use pg_config.h, not mangle postgres_ext.h like that.  Or
maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but
I wouldn't do that, really).

-- 
Alvaro Herrerahttp://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [PATCHES] Allow the identifier length to be increased via a configure option

[Tom Lane]

Alvaro Herrera [EMAIL PROTECTED] writes:
 Dhanaraj M wrote:
 I am sending the patch for the following TODO item:
 Allow the identifier length to be increased via a configure option

 You should use pg_config.h, not mangle postgres_ext.h like that.  Or
 maybe generate postgres_ext.h from an hypotetical postgres_ext.h.in (but
 I wouldn't do that, really).

I'm wondering how this got into the TODO list.  It seems rather
pointless, and likely to create client compatibility problems (if not,
why is NAMEDATALEN exported at all?)

A bigger problem with the proposed patch is that it makes it look like
you can set the identifier length to any random number; the restrictions
mentioned in postgres_ext.h aren't enforced or even displayed to the
user of configure.

regards, tom lane

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster