Re: [PATCHES] Another Plpgsql trigger example - summary table

2005-01-14 Thread Mark Kirkwood
Mark Kirkwood wrote: Looking at option 2, it seems reasonable to add a trimmed trigger example into the plpgsql examples section now, and leave the data warehouse introductory stuff for its own chapter at some later stage. Sorry about this - A amendment so as not not require a SELECT from the

Re: [PATCHES] Another Plpgsql trigger example - summary table

2005-01-14 Thread Tom Lane
Mark Kirkwood [EMAIL PROTECTED] writes: A amendment so as not not require a SELECT from the main table in the trigger procedure. This makes the intent of the code more obvious, and makes more sense within the context of the example. Yeah, much better. Applied.

Re: [PATCHES] Another Plpgsql trigger example - summary table

2005-01-13 Thread Tom Lane
Mark Kirkwood [EMAIL PROTECTED] writes: Looking at option 2, it seems reasonable to add a trimmed trigger example into the plpgsql examples section now, and leave the data warehouse introductory stuff for its own chapter at some later stage. Patch applied. regards,

Re: [PATCHES] Another Plpgsql trigger example - summary table

2005-01-10 Thread Mark Kirkwood
Mark Kirkwood wrote: 2) Perhaps leave the trigger + plpgsql function as a plpgsql example, and refer to it in the (new) data warehouse section/chapter. Looking at option 2, it seems reasonable to add a trimmed trigger example into the plpgsql examples section now, and leave the data warehouse

Re: [PATCHES] Another Plpgsql trigger example - summary table

2005-01-04 Thread Mark Kirkwood
Bruce Momjian wrote: Wow, yea, that is long. Not sure where that should go. hmmm, yep - I could shorten it by removing : - the COPY, ANALYZE (and maybe some of the INDEX) statements - the queries and EXPLAINS at the end However, this means that it is not clear what the point of the exercise is

Re: [PATCHES] Another Plpgsql trigger example - summary table

2005-01-03 Thread Bruce Momjian
Wow, yea, that is long. Not sure where that should go. --- Mark Kirkwood wrote: I have always thought that an example of how to maintain a summary table via triggers would be nice... but until the other day, had not