Re: [PATCHES] Default location for docbook stylesheets in Gentoo

2007-08-08 Thread Neil Conway 
On Thu, 2007-08-09 at 04:08 +1000, Brendan Jurd wrote:
 This patch adds the default location for the DocBook DSSSL stylesheets
 in gentoo's package system to the configure script.

FYI, patches should typically be submitted as context diffs. For the
specific case of configure, you should submit patches against the source
file (configure.in), not the generated file (configure).

-Neil



---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] Default location for docbook stylesheets in Gentoo

2007-08-08 Thread Peter Eisentraut 
Brendan Jurd wrote:
 This patch adds the default location for the DocBook DSSSL
 stylesheets in gentoo's package system to the configure script.

Uh, could you please send a diff with -u or -c, so we know where to put 
the change?

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [PATCHES] Default location for docbook stylesheets in Gentoo

2007-08-08 Thread Brendan Jurd 
On 8/9/07, Neil Conway [EMAIL PROTECTED] wrote:
 FYI, patches should typically be submitted as context diffs. For the
 specific case of configure, you should submit patches against the source
 file (configure.in), not the generated file (configure).

Apologies.  I haven't done much dev involving autoconf, so it didn't
occur to me that configure wasn't a source.

Is the following a reasonable way to test my changes?

$ rm configure
$ autoconf
$ ./configure

New (context) diff attached.  The actual change is in
config/docbook.m4, not configure.in.

Cheers
BJ
Index: config/docbook.m4
===
RCS file: /projects/cvsroot/pgsql/config/docbook.m4,v
retrieving revision 1.7
diff -c -r1.7 docbook.m4
*** config/docbook.m4   13 Dec 2003 20:25:18 -  1.7
--- config/docbook.m4   8 Aug 2007 19:00:26 -
***
*** 60,66 
for pgac_postfix in \
  sgml/stylesheets/nwalsh-modular \
  sgml/stylesheets/docbook \
!   sgml/docbook-dsssl \
  sgml/docbook/dsssl/modular \
  sgml/docbook/stylesheet/dsssl/modular \
  sgml/docbook/dsssl-stylesheets
--- 60,67 
for pgac_postfix in \
  sgml/stylesheets/nwalsh-modular \
  sgml/stylesheets/docbook \
! sgml/stylesheets/dsssl/docbook \
! sgml/docbook-dsssl \
  sgml/docbook/dsssl/modular \
  sgml/docbook/stylesheet/dsssl/modular \
  sgml/docbook/dsssl-stylesheets

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] Default location for docbook stylesheets in Gentoo

2007-08-08 Thread Tom Lane 
Brendan Jurd [EMAIL PROTECTED] writes:
 New (context) diff attached.  The actual change is in
 config/docbook.m4, not configure.in.

Much better.  Committed in HEAD and REL8_2 (I suppose Gentoo weenies
won't be interested in anything older ;-))

regards, tom lane

---(end of broadcast)---
TIP 9: In versions below 8.0, the planner will ignore your desire to
   choose an index scan if your joining column's datatypes do not
   match