Re: [PATCHES] GUC description cleanup

2006-12-06 Thread Neil Conway
On Sat, 2006-12-02 at 22:51 -0500, Tom Lane wrote: > The bgwriter parameter descriptions seem still, well, not good English. Indeed, there is still plenty of room for improvement, but exam period prevents me from attempting anything more extensive at the moment... Patch applied to HEAD. -Neil

Re: [PATCHES] GUC description cleanup

2006-12-02 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Attached is a revised version of this patch. The bgwriter parameter descriptions seem still, well, not good English. For instance > ! gettext_noop("Background writer maximum number of LRU > pages to flush per round."), ISTM this woul

Re: [PATCHES] GUC description cleanup

2006-12-02 Thread Neil Conway
On Fri, 2006-10-27 at 10:56 -0400, Neil Conway wrote: > Sure, I'll wait for 8.3 to branch. Attached is a revised version of this patch. I added a description for pre_auth_delay (rather than removing it from SHOW ALL). I also removed explicit mention of units from a bunch of description strings, si

Re: [PATCHES] GUC description cleanup

2006-10-27 Thread Neil Conway
On Fri, 2006-10-27 at 15:59 +0200, Peter Eisentraut wrote: > I appreciate this effort, but I think it's better to hold the patch. Sure, I'll wait for 8.3 to branch. -Neil ---(end of broadcast)--- TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] GUC description cleanup

2006-10-27 Thread Peter Eisentraut
Am Donnerstag, 26. Oktober 2006 19:47 schrieb Neil Conway: > Note that this patch breaks the translations of these strings, so I > haven't applied it yet. Should I apply it now, or wait for 8.3 to > branch? I appreciate this effort, but I think it's better to hold the patch. -- Peter Eisentraut

Re: [PATCHES] GUC description cleanup

2006-10-26 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > Note that this patch breaks the translations of these strings, so I > haven't applied it yet. Should I apply it now, or wait for 8.3 to > branch? BTW, unless Peter says it's OK, my advice is to wait. It's already likely to be the case that translation upd

Re: [PATCHES] GUC description cleanup

2006-10-26 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > BTW, should pre_auth_delay be included in SHOW ALL? It's really just a debug aid, so I wouldn't complain if SHOW ALL didn't show it. regards, tom lane ---(end of broadcast)--- TIP 3: