Re: [PATCHES] GUC description cleanup

2006-12-06 Thread Neil Conway 
On Sat, 2006-12-02 at 22:51 -0500, Tom Lane wrote:
> The bgwriter parameter descriptions seem still, well, not good English.

Indeed, there is still plenty of room for improvement, but exam period
prevents me from attempting anything more extensive at the moment...

Patch applied to HEAD.

-Neil



---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [PATCHES] GUC description cleanup

2006-12-02 Thread Tom Lane 
Neil Conway <[EMAIL PROTECTED]> writes:
> Attached is a revised version of this patch.

The bgwriter parameter descriptions seem still, well, not good English.
For instance

> ! gettext_noop("Background writer maximum number of LRU 
> pages to flush per round."),

ISTM this would read better as
Maximum number of LRU pages to flush per activity round in the 
background writer.
or something else that betrays some understanding of English grammar ...

regards, tom lane

---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [PATCHES] GUC description cleanup

2006-12-02 Thread Neil Conway 
On Fri, 2006-10-27 at 10:56 -0400, Neil Conway wrote:
> Sure, I'll wait for 8.3 to branch.

Attached is a revised version of this patch. I added a description for
pre_auth_delay (rather than removing it from SHOW ALL). I also removed
explicit mention of units from a bunch of description strings, since
after Peter's work for 8.2, some configuration variables can be
specified or displayed in several possible units. For example, the
current output from SHOW ALL is:

deadlock_timeout | 1s | The time in milliseconds to wait on lock before
checking for deadlock.

... which is plainly not a value "in milliseconds".

Barring any objections, I'll apply this to 8.3 (HEAD) tomorrow.

-Neil

Index: src/backend/utils/misc/guc.c
===
RCS file: /home/neilc/postgres/cvs_root/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.360
diff -c -p -r1.360 guc.c
*** src/backend/utils/misc/guc.c	29 Nov 2006 14:50:07 -	1.360
--- src/backend/utils/misc/guc.c	2 Dec 2006 19:28:33 -
*** static struct config_bool ConfigureNames
*** 587,593 
  	{
  		/* currently undocumented, so don't show in SHOW ALL */
  		{"exit_on_error", PGC_USERSET, UNGROUPED,
! 			gettext_noop("no description available"),
  			NULL,
  			GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE
  		},
--- 587,593 
  	{
  		/* currently undocumented, so don't show in SHOW ALL */
  		{"exit_on_error", PGC_USERSET, UNGROUPED,
! 			gettext_noop("No description available."),
  			NULL,
  			GUC_NO_SHOW_ALL | GUC_NOT_IN_SAMPLE
  		},
*** static struct config_bool ConfigureNames
*** 669,675 
  #ifdef BTREE_BUILD_STATS
  	{
  		{"log_btree_build_stats", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("no description available"),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
--- 669,675 
  #ifdef BTREE_BUILD_STATS
  	{
  		{"log_btree_build_stats", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("No description available."),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
*** static struct config_bool ConfigureNames
*** 761,767 
  #ifdef LOCK_DEBUG
  	{
  		{"trace_locks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("no description available"),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
--- 761,767 
  #ifdef LOCK_DEBUG
  	{
  		{"trace_locks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("No description available."),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
*** static struct config_bool ConfigureNames
*** 770,776 
  	},
  	{
  		{"trace_userlocks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("no description available"),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
--- 770,776 
  	},
  	{
  		{"trace_userlocks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("No description available."),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
*** static struct config_bool ConfigureNames
*** 779,785 
  	},
  	{
  		{"trace_lwlocks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("no description available"),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
--- 779,785 
  	},
  	{
  		{"trace_lwlocks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("No description available."),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
*** static struct config_bool ConfigureNames
*** 788,794 
  	},
  	{
  		{"debug_deadlocks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("no description available"),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
--- 788,794 
  	},
  	{
  		{"debug_deadlocks", PGC_SUSET, DEVELOPER_OPTIONS,
! 			gettext_noop("No description available."),
  			NULL,
  			GUC_NOT_IN_SAMPLE
  		},
*** static struct config_bool ConfigureNames
*** 982,988 
  
  	{
  		{"standard_conforming_strings", PGC_USERSET, COMPAT_OPTIONS_PREVIOUS,
! 			gettext_noop("'...' strings treat backslashes literally."),
  			NULL,
  			GUC_REPORT
  		},
--- 982,988 
  
  	{
  		{"standard_conforming_strings", PGC_USERSET, COMPAT_OPTIONS_PREVIOUS,
! 			gettext_noop("Causes '...' strings to treat backslashes literally."),
  			NULL,
  			GUC_REPORT
  		},
*** static struct config_int ConfigureNamesI
*** 1050,1057 
  	},
  	{
  		{"from_collapse_limit", PGC_USERSET, QUERY_TUNING_OTHER,
! 			gettext_noop("Sets the FROM-list size beyond which subqueries are not "
! 		 "collapsed."),
  			gettext_noop("The planner will merge subqueries into upper "
  "queries if the resulting FROM list would have no more than "
  		 "this many items.")
--- 1050,1057 
  	},
  	{
  		{"from_collapse_limit", PGC_USERSET, QUERY_TUNING_OTHER,
! 			gettext_noop("Sets the FROM-list size beyond which subqueries "
! 		 "are not collapsed."),
  			gettext_noop("The planner will merge subqueries into upper "
  "queries if the resulting FROM list would have no more than "
  		 "this many items.")
*** static struct config_int ConfigureNamesI
*** 1061,1071 
  	},
  	{
  		{"join_collapse_limit", PGC_USERSET, QUERY_TUN

Re: [PATCHES] GUC description cleanup

2006-10-27 Thread Neil Conway 
On Fri, 2006-10-27 at 15:59 +0200, Peter Eisentraut wrote:
> I appreciate this effort, but I think it's better to hold the patch.

Sure, I'll wait for 8.3 to branch.

-Neil



---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] GUC description cleanup

2006-10-27 Thread Peter Eisentraut 
Am Donnerstag, 26. Oktober 2006 19:47 schrieb Neil Conway:
> Note that this patch breaks the translations of these strings, so I
> haven't applied it yet. Should I apply it now, or wait for 8.3 to
> branch?

I appreciate this effort, but I think it's better to hold the patch.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

---(end of broadcast)---
TIP 5: don't forget to increase your free space map settings

Re: [PATCHES] GUC description cleanup

2006-10-26 Thread Tom Lane 
Neil Conway <[EMAIL PROTECTED]> writes:
> Note that this patch breaks the translations of these strings, so I
> haven't applied it yet. Should I apply it now, or wait for 8.3 to
> branch?

BTW, unless Peter says it's OK, my advice is to wait.  It's already
likely to be the case that translation updates are the critical path
for releasing 8.2.

regards, tom lane

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq

Re: [PATCHES] GUC description cleanup

2006-10-26 Thread Tom Lane 
Neil Conway <[EMAIL PROTECTED]> writes:
> BTW, should pre_auth_delay be included in SHOW ALL?

It's really just a debug aid, so I wouldn't complain if SHOW ALL didn't
show it.

regards, tom lane

---(end of broadcast)---
TIP 3: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faq