Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-04-17 Thread Heikki Linnakangas
Simon Riggs wrote: New functions to examine the contents of heap pages, as discussed recently on -hackers. These are fully integrated into backend. ... I'll maintain this with immediate fixes/additions as we go up to 8.3 and beyond, to assist review process of various patches that alter page

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-04-08 Thread Simon Riggs
On Sat, 2007-04-07 at 18:19 -0400, Bruce Momjian wrote: Simon Riggs wrote: On Sat, 2007-04-07 at 11:53 -0400, Bruce Momjian wrote: This looks useful, but shouldn't it be part of /contrib/pgstattuple rather than in the backend? Well, this was written with a view to it being usable

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-04-07 Thread Bruce Momjian
This looks useful, but shouldn't it be part of /contrib/pgstattuple rather than in the backend? --- Simon Riggs wrote: New functions to examine the contents of heap pages, as discussed recently on -hackers. These are

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-04-07 Thread Simon Riggs
On Sat, 2007-04-07 at 11:53 -0400, Bruce Momjian wrote: This looks useful, but shouldn't it be part of /contrib/pgstattuple rather than in the backend? Well, this was written with a view to it being usable for writing test cases that checked the various tuple states as we went. It was

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-04-07 Thread Bruce Momjian
Simon Riggs wrote: On Sat, 2007-04-07 at 11:53 -0400, Bruce Momjian wrote: This looks useful, but shouldn't it be part of /contrib/pgstattuple rather than in the backend? Well, this was written with a view to it being usable for writing test cases that checked the various tuple states

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-04-07 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: If we see it as a manual test tool only, contrib is OK. But it has to be in the backend to be usable in the regression test suite, so thats where it was designed to go. The core regression tests have depended on some contrib stuff forever, so the above

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. ---

Re: [PATCHES] Heap page diagnostic/test functions (v2)

2007-03-08 Thread Simon Riggs
On Thu, 2007-03-08 at 15:44 +, Simon Riggs wrote: Docs included Just noticed a typo. File mentioned in func.sgml, line 11049 should be filenamesrc/include/access/htup.h/ and not filenamesrc/include/storage/bufpage.h/ -- Simon Riggs EnterpriseDB