> [snip]
> #ifndef WIN32
> #define pgpipe(a) pipe(a)
> #define piperead(a,b,c) read(a,b,c)
> #define pipewrite(a,b,c)write(a,b,c)
> #else
> extern int pgpipe(int handles[2]);
> extern int piperead(a,b,c);
> extern int pipewrite(a,b,c);
> #endif
>
> And then
> > A thought about this - how about converting pgpiperead() and
> > pgpipewrite() into functions intead of macros (on win32 - still
> > redifining them on != win32), mimicking the behaviour of read() and
> > write()?
>
> And #def'ing them to be read + write under win32? Don't want
> to change
Patch applied. Thanks.
---
Claudio Natoli wrote:
>
> For application to HEAD, following community review.
>
> Corrects issues recently posted by Dann Corbit, allowing libpq/psql to be
> built under VC++. Moves a pgstat w
> A thought about this - how about converting pgpiperead() and
> pgpipewrite() into functions intead of macros (on win32 - still
> redifining them on != win32), mimicking the behaviour of read() and
> write()?
And #def'ing them to be read + write under win32? Don't want to change every
instance
A thought about this - how about converting pgpiperead() and
pgpipewrite() into functions intead of macros (on win32 - still
redifining them on != win32), mimicking the behaviour of read() and
write()? Then we could do awya with the #ifdefs at the points where its
used, and just expect the normal U
