Re: [PATCHES] MSVC build broken (again)

2006-10-03 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> Would it be possible to move the whole block into win32.h? > Nope, it needs to go before and friends, unfortunatly. OK, patch committed as-is then. The whole thing still looks awfully icky though, particularly the way pg_config_os.h is included

Re: [PATCHES] MSVC build broken (again)

2006-10-03 Thread Magnus Hagander
> > The code around errcode is definitly messy. In CVS now, it actually > > renames *our* errcode() function to __msvc_errcode, and > exports this > > from postgres.exe. This is definitly very borken. > > Would it be possible to move the whole block into win32.h? > This would cause it to be in

Re: [PATCHES] MSVC build broken (again)

2006-10-03 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > The code around errcode is definitly messy. In CVS now, it actually > renames *our* errcode() function to __msvc_errcode, and exports this > from postgres.exe. This is definitly very borken. Would it be possible to move the whole block into win32.h?