Re: [PATCHES] Micro doc patch (plpgsql)

2006-12-26 Thread Tom Lane 
"Joachim Wieland" <[EMAIL PROTECTED]> writes:
> attached is a micro doc patch. BEGIN in plpgsql is without semicolon.

Applied, thanks.

regards, tom lane

---(end of broadcast)---
TIP 7: You can help support the PostgreSQL project by donating at

http://www.postgresql.org/about/donate

Re: [PATCHES] Micro doc patch (plpgsql)

2006-12-26 Thread David Fetter 
On Tue, Dec 26, 2006 at 01:10:03PM +0100, Joachim Wieland wrote:
> On December 26, 5:19 am David Fetter <[EMAIL PROTECTED]> wrote:
> > It doesn't need the semicolon.  PL/PgSQL's BEGIN is different from
> > SQL's. :)
> 
> Exactly. Note that my patch _removes_ the semicolon. If you put it in a
> plpgsql function definition as in the example from the docs you get a
> syntax error.

Oops.  Sorry about that :)

Cheers,
D
> 
> 
> > >  -BEGIN;
> > >  +BEGIN
> 
> 
> Joachim

-- 
David Fetter <[EMAIL PROTECTED]> http://fetter.org/
phone: +1 415 235 3778AIM: dfetter666
  Skype: davidfetter

Remember to vote!

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [PATCHES] Micro doc patch (plpgsql)

2006-12-26 Thread Joachim Wieland 
On December 26, 5:19 am David Fetter <[EMAIL PROTECTED]> wrote:
> It doesn't need the semicolon.  PL/PgSQL's BEGIN is different from
> SQL's. :)

Exactly. Note that my patch _removes_ the semicolon. If you put it in a
plpgsql function definition as in the example from the docs you get a
syntax error.


> >  -BEGIN;
> >  +BEGIN


Joachim

---(end of broadcast)---
TIP 2: Don't 'kill -9' the postmaster

Re: [PATCHES] Micro doc patch (plpgsql)

2006-12-25 Thread David Fetter 
On Tue, Dec 26, 2006 at 01:36:07AM +0100, Joachim Wieland wrote:
> Hi,
> 
> attached is a micro doc patch. BEGIN in plpgsql is without semicolon.

It doesn't need the semicolon.  PL/PgSQL's BEGIN is different from
SQL's. :)

Cheers,
D
> 
> 
> Joachim

> diff -ur cvs/pgsql/doc/src/sgml/plpgsql.sgml 
> cvs.build/pgsql/doc/src/sgml/plpgsql.sgml
> --- cvs/pgsql/doc/src/sgml/plpgsql.sgml   2006-11-01 05:09:40.0 
> +0100
> +++ cvs.build/pgsql/doc/src/sgml/plpgsql.sgml 2006-12-25 11:17:04.0 
> +0100
> @@ -1243,7 +1243,7 @@
>   to catch the error, for example:
>  
>  
> -BEGIN;
> +BEGIN
>  SELECT * INTO STRICT myrec FROM emp WHERE empname = myname;
>  EXCEPTION
>  WHEN NO_DATA_FOUND THEN

> 
> ---(end of broadcast)---
> TIP 2: Don't 'kill -9' the postmaster


-- 
David Fetter <[EMAIL PROTECTED]> http://fetter.org/
phone: +1 415 235 3778AIM: dfetter666
  Skype: davidfetter

Remember to vote!

---(end of broadcast)---
TIP 6: explain analyze is your friend

Re: [PATCHES] Micro-doc patch for CREATE FUNCTION

2006-11-02 Thread Tom Lane 
"Joachim Wieland" <[EMAIL PROTECTED]> writes:
> It is not obvious that a function should be declared "RETURNS VOID" if it
> is not supposed to return a value.

Done, thanks.

regards, tom lane

---(end of broadcast)---
TIP 4: Have you searched our list archives?

   http://archives.postgresql.org

Re: [PATCHES] Micro doc patch

2005-05-13 Thread Tom Lane 
"Dave Page"  writes:
> Add missing quotes.

Done, thanks.

regards, tom lane

---(end of broadcast)---
TIP 8: explain analyze is your friend