bruce wrote:
>
> Patch applied. Thanks.
>
> I had to convert a lot of whitespace to tabs. It wasn't just the
> whitespace, but whitespace that was 8 spaces. I assume you are reading
> our code using an 8-space tab. Please see the developer's FAQ and try
> to use tabs in future patches. Thank
Patch applied. Thanks.
I had to convert a lot of whitespace to tabs. It wasn't just the
whitespace, but whitespace that was 8 spaces. I assume you are reading
our code using an 8-space tab. Please see the developer's FAQ and try
to use tabs in future patches. Thanks.
---
Hi Alvaro
Thanks for your valuable suggestions.
I made the changes as suggested earlier.
Please review again and comment on this.
I like to make changes if it is required.
*** ./src/backend/commands/portalcmds.c.orig Sat Aug 12 23:04:54 2006
--- ./src/backend/commands/portalcmds.c Fri Aug 18 22:5
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> I'm not sure that I see the point of this at all. ISTM the entire
>> reason for using a cursor is that you're going to fetch the results
>> in bite-size pieces. I don't see the current Postgres source code
>> surviving into the era wh
Tom Lane wrote:
> Alvaro Herrera <[EMAIL PROTECTED]> writes:
> > I don't think this is the right approach. Maybe it would be reasonable
> > to add another arm to the %union instead, not sure. The problem is the
> > amount of ugly casts you have to use below. The scanner code seems to
> > think t
Alvaro Herrera <[EMAIL PROTECTED]> writes:
> I don't think this is the right approach. Maybe it would be reasonable
> to add another arm to the %union instead, not sure. The problem is the
> amount of ugly casts you have to use below. The scanner code seems to
> think that a constant larger than
Dhanaraj M wrote:
I had a quick look:
> ***
> *** 209,215
>
> /* Return command status if wanted */
> if (completionTag)
> ! snprintf(completionTag, COMPLETION_TAG_BUFSIZE, "%s %ld",
>stmt->ismove ? "MOVE" : "FETCH",
>
