Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Bruce Momjian <[EMAIL PROTECTED]> writes: >>> ! if (SOCK_ERRNO != ECONNRESET) >>> ! SSL_shutdown(conn->ssl); >> >> Ummm ... what is this supposed to fix exactly, and what are the odds > I think the user was getting SIGPIPE on SSL_shutdown() of a closed > connection. It seems moderately improbable that by the time control arrives here, errno still has anything to do with the last operation on the SSL socket. regards, tom lane ---(end of broadcast)--- TIP 7: You can help support the PostgreSQL project by donating at http://www.postgresql.org/about/donate
Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > ! if (SOCK_ERRNO != ECONNRESET) > > ! SSL_shutdown(conn->ssl); > > Ummm ... what is this supposed to fix exactly, and what are the odds I think the user was getting SIGPIPE on SSL_shutdown() of a closed connection. > that it will introduce resource leaks? I don't know myself. If some SSL expert says it is OK, we apply it, if not, we ignore the patch. -- Bruce Momjian <[EMAIL PROTECTED]> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of broadcast)--- TIP 4: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] Re: [BUGS] BUG #2724: Could not check connection status with "ssl=on"
Bruce Momjian <[EMAIL PROTECTED]> writes: > ! if (SOCK_ERRNO != ECONNRESET) > ! SSL_shutdown(conn->ssl); Ummm ... what is this supposed to fix exactly, and what are the odds that it will introduce resource leaks? regards, tom lane ---(end of broadcast)--- TIP 6: explain analyze is your friend
