Re: [PATCHES] Refactoring xlogutils.c

2008-06-11 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> The code motion in md.c looks fairly bogus; was that a copy-and-paste >> error? > That's intentional. That check has been moved to smgrcreate(), so that > it's done before calling TablespaceCreateDbSpace(). The reason for that

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Heikki Linnakangas
Tom Lane wrote: "Heikki Linnakangas" <[EMAIL PROTECTED]> writes: Attached is an updated version of my patch to refactor the XLogOpenRelation/XLogReadBuffer interface, in preparation for the relation forks patch, and subsequently the FSM rewrite patch. The code motion in md.c looks fairly bogu

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Heikki Linnakangas
Teodor Sigaev wrote: - For the routines that need a fake, or lightweight, Relation struct anyway, there's a new function called XLogFakeRelcacheEntry(RelFileNode), that returns a palloc'd Relation struct. Is that fake structure applicable for ReadBuffer()? Yes. -- Heikki Linnakangas En

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Teodor Sigaev
- For the routines that need a fake, or lightweight, Relation struct anyway, there's a new function called XLogFakeRelcacheEntry(RelFileNode), that returns a palloc'd Relation struct. Is that fake structure applicable for ReadBuffer()? ginContinueSplit() calls findParents() with a fake Relatio

Re: [PATCHES] Refactoring xlogutils.c

2008-06-10 Thread Tom Lane
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > Attached is an updated version of my patch to refactor the > XLogOpenRelation/XLogReadBuffer interface, in preparation for the > relation forks patch, and subsequently the FSM rewrite patch. The code motion in md.c looks fairly bogus; was that a