Re: [PATCHES] Removal of win32-specific rename code
> If your fix works, I will change the Win32-specific code to use open() > and fdopen(). The only advantage to the old code was that it would > release locks, then go into a rename loop, which is horid, and we need > to avoid the loop. Ah, I see. Should've been obvious you had that in mind actually. Great! Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em ailpolicy.html ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
Re: [PATCHES] Removal of win32-specific rename code
Claudio Natoli wrote: > > > main file. WIth Claudio's fix, this isn't necessary. > > Bruce, are you sure this is true? The fix is only for files than are > open()'d, not fopen()'d (as per AllocateFile). If your fix works, I will change the Win32-specific code to use open() and fdopen(). The only advantage to the old code was that it would release locks, then go into a rename loop, which is horid, and we need to avoid the loop. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster
Re: [PATCHES] Removal of win32-specific rename code
> main file. WIth Claudio's fix, this isn't necessary. Bruce, are you sure this is true? The fix is only for files than are open()'d, not fopen()'d (as per AllocateFile). Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/emailpolicy.html";>http://www.memetrics.com/em ailpolicy.html ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])
