Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-13 Thread Bruce Momjian
Greg Sabino Mullane wrote:
[ There is text before PGP section. ]
> 
[ PGP not available, raw data follows ]
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>  
>  
> > No reason Greg can't do it if he wants to ... but the .sample file
> > itself is certainly not all that needs changing.
>  
> No problem. I didn't expect the patch to pass as is, just wanted
> to get my foot in the door. :)

However, this has to be considered a feature addition after feature
freeze so I am not sure we are going to do this for 7.5.

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-13 Thread Greg Sabino Mullane

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
 
 
> No reason Greg can't do it if he wants to ... but the .sample file
> itself is certainly not all that needs changing.
 
No problem. I didn't expect the patch to pass as is, just wanted
to get my foot in the door. :)
 
- --
Greg Sabino Mullane [EMAIL PROTECTED]
PGP Key: 0x14964AC8 200407130745
-BEGIN PGP SIGNATURE-
 
iD8DBQFA88txvJuQZxSWSsgRAtVJAKD8oWEHqudEOQAw5H4aZM9xYmBEJQCgriKb
gdWb6Xkpfy9Dyy837TJ+to8=
=z0P0
-END PGP SIGNATURE-



---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html


Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-12 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Uh, it is my understanding that all lines can't be uncommented.  Some of
> the lines have defaults that are computed, like fsync_method.

Yes, fsync_method shouldn't be uncommented unless you're prepared to put
in the same default value presently computed in xlog.c.  (Now that
initdb is in C, it might not be unreasonable to move the #ifdef hacking
that's in xlog.c over to initdb...)

Also you'd need to make some other adjustments in initdb; IIRC it does
sed-like substitutions that will break if the input is not just so.
I don't recall at the moment but there may be some things of the same
ilk done during "make install".  And check the documentation to see if
any discussion needs updated.

> Anyway, we are too busy to consider this for 7.5 unless someone wants to
> research all these issues.

No reason Greg can't do it if he wants to ... but the .sample file
itself is certainly not all that needs changing.

regards, tom lane

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


Re: [PATCHES] Remove confusing commented-defaullts from postgresql.conf

2004-07-12 Thread Bruce Momjian

Uh, it is my understanding that all lines can't be uncommented.  Some of
the lines have defaults that are computed, like fsync_method.

Anyway, we are too busy to consider this for 7.5 unless someone wants to
research all these issues.

---

Greg Sabino Mullane wrote:
[ There is text before PGP section. ]
> 
[ PGP not available, raw data follows ]
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
> NotDashEscaped: You need GnuPG to verify this message
> 
> 
> I know we never reached a full consensus on hackers about the 
> full solution to the postgresql.conf file, but I think everyone 
> agreed that having commented-out "default" values was a bad thing, 
> which caused confusion among even seasoned pg people. Thus, the 
> patch below which simply removes the starting '#' from all settings. 
> Forgive the lack of -c to the diff: I figured saving space was 
> more important as the context is not needed in this case.
> 
> --
> Greg Sabino Mullane [EMAIL PROTECTED]
> PGP Key: 0x14964AC8 200407122051
> 
> 
> 
> 
> Index: postgresql.conf.sample
> ===
> RCS file: 
> /projects/cvsroot/pgsql-server/src/backend/utils/misc/postgresql.conf.sample,v
> retrieving revision 1.115
> diff -r1.115 postgresql.conf.sample
> 5c5
> < # This file consists of lines of the form:
> ---
> > # This file consists of lines of the form: GREG
> 11,12c11
> < # allowed values can be found in the PostgreSQL documentation. The
> < # commented-out settings shown in this file represent the default values.
> ---
> > # allowed values can be found in the PostgreSQL documentation. 
> 28,31c27,30
> < # pgdata = '/usr/local/pgsql/data'  # use data in another directory
> < # hba_conf = '/etc/pgsql/pg_hba.conf'   # use hba info in another 
> directory
> < # ident_conf = '/etc/pgsql/pg_ident.conf'   # use ident info in another directory
> < # external_pidfile= '/var/run/postgresql.pid'   # write an extra pid file
> ---
> > pgdata = '/usr/local/pgsql/data'# use data in another directory
> > hba_conf = '/etc/pgsql/pg_hba.conf' # use hba info in another 
> > directory
> > ident_conf = '/etc/pgsql/pg_ident.conf' # use ident info in another directory
> > external_pidfile= '/var/run/postgresql.pid' # write an extra pid file
> 40c39
> < #listen_addresses = 'localhost' # what IP interface(s) to listen on; 
> ---
> > listen_addresses = 'localhost'  # what IP interface(s) to listen on; 
> 42,43c41,42
> < #port = 5432
> < #max_connections = 100
> ---
> > port = 5432
> > max_connections = 100
> 47,51c46,50
> < #superuser_reserved_connections = 2
> < #unix_socket_directory = ''
> < #unix_socket_group = ''
> < #unix_socket_permissions = 0777 # octal
> < #rendezvous_name = ''   # defaults to the computer name
> ---
> > superuser_reserved_connections = 2
> > unix_socket_directory = ''
> > unix_socket_group = ''
> > unix_socket_permissions = 0777  # octal
> > rendezvous_name = ''# defaults to the computer name
> 55,59c54,58
> < #authentication_timeout = 60# 1-600, in seconds
> < #ssl = false
> < #password_encryption = true
> < #krb_server_keyfile = ''
> < #db_user_namespace = false
> ---
> > authentication_timeout = 60 # 1-600, in seconds
> > ssl = false
> > password_encryption = true
> > krb_server_keyfile = ''
> > db_user_namespace = false
> 68,77c67,76
> < #shared_buffers = 1000  # min 16, at least max_connections*2, 8KB each
> < #work_mem = 1024# min 64, size in KB
> < #maintenance_work_mem = 16384   # min 1024, size in KB
> < #max_stack_depth = 2048 # min 100, size in KB
> < 
> < #vacuum_cost_page_hit = 1   # 0-1 credits
> < #vacuum_cost_page_miss = 10 # 0-1 credits
> < #vacuum_cost_page_dirty = 20# 0-1 credits
> < #vacuum_cost_limit = 200# 0-1 credits
> < #vacuum_cost_naptime = 50   # 0-1000 milliseconds
> ---
> > shared_buffers = 1000   # min 16, at least max_connections*2, 8KB each
> > work_mem = 1024 # min 64, size in KB
> > maintenance_work_mem = 16384# min 1024, size in KB
> > max_stack_depth = 2048  # min 100, size in KB
> > 
> > vacuum_cost_page_hit = 1# 0-1 credits
> > vacuum_cost_page_miss = 10  # 0-1 credits
> > vacuum_cost_page_dirty = 20 # 0-1 credits
> > vacuum_cost_limit = 200 # 0-1 credits
> > vacuum_cost_naptime = 50# 0-1000 milliseconds
> 80,82c79,81
> < #bgwriter_delay = 200   # 10-5000 milliseconds
> < #bgwriter_percent = 1   # 0-100% of dirty buffers
> < #bgwriter_maxpages = 100# 1-1000 buffers max at once
> ---
> > bgwriter_delay = 200# 10-5000 milliseconds
> > bgwriter_percent = 1# 0-100% of dirty buffers
> > bgwriter_maxpages = 100 # 1-1000 buffers max at once
> 86,87c85,86
> < #max_fsm_pages = 2